X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/dbb3be0a748de0be8075d78de42199d80aaf3a47..e6b0e1ae7ef45b87a61f18bb50296273d6dd1bfb:/app/assets/javascripts/user.js?ds=sidebyside

diff --git a/app/assets/javascripts/user.js b/app/assets/javascripts/user.js
index 24506b4b4..2af9e18cb 100644
--- a/app/assets/javascripts/user.js
+++ b/app/assets/javascripts/user.js
@@ -1,7 +1,14 @@
-//= require leaflet.locatecontrol/src/L.Control.Locate
+//= require leaflet.locatecontrol/dist/L.Control.Locate.umd
+
+(function () {
+  $(document).on("change", "#user_all", function () {
+    $("#user_list input[type=checkbox]").prop("checked", $("#user_all").prop("checked"));
+  });
+}());
 
 $(document).ready(function () {
-  var map, marker, deleted_lat, deleted_lon;
+  const defaultHomeZoom = 12;
+  let map, marker, deleted_lat, deleted_lon;
 
   if ($("#map").length) {
     map = L.map("map", {
@@ -9,12 +16,12 @@ $(document).ready(function () {
       zoomControl: false
     }).addLayer(new L.OSM.Mapnik());
 
-    var position = $("html").attr("dir") === "rtl" ? "topleft" : "topright";
+    const position = $("html").attr("dir") === "rtl" ? "topleft" : "topright";
 
     L.OSM.zoom({ position: position })
       .addTo(map);
 
-    var locate = L.control.locate({
+    const locate = L.control.locate({
       position: position,
       icon: "icon geolocate",
       iconLoading: "icon geolocate",
@@ -26,7 +33,7 @@ $(document).ready(function () {
       }
     }).addTo(map);
 
-    var locateContainer = locate.getContainer();
+    const locateContainer = locate.getContainer();
 
     $(locateContainer)
       .removeClass("leaflet-control-locate leaflet-bar")
@@ -37,13 +44,17 @@ $(document).ready(function () {
       .addClass("control-button");
 
     if (OSM.home) {
-      map.setView([OSM.home.lat, OSM.home.lon], 12);
+      map.setView([OSM.home.lat, OSM.home.lon], defaultHomeZoom);
     } else {
       map.setView([0, 0], 0);
     }
 
     if ($("#map").hasClass("set_location")) {
-      marker = L.marker([0, 0], { icon: OSM.getUserIcon() });
+      marker = L.marker([0, 0], {
+        icon: OSM.getUserIcon(),
+        keyboard: false,
+        interactive: false
+      });
 
       if (OSM.home) {
         marker.setLatLng([OSM.home.lat, OSM.home.lon]);
@@ -53,16 +64,28 @@ $(document).ready(function () {
       map.on("click", function (e) {
         if (!$("#updatehome").is(":checked")) return;
 
-        var zoom = map.getZoom(),
-            precision = OSM.zoomPrecision(zoom),
-            location = e.latlng.wrap();
+        const [lat, lon] = OSM.cropLocation(e.latlng, map.getZoom());
 
-        $("#home_lat").val(location.lat.toFixed(precision));
-        $("#home_lon").val(location.lng.toFixed(precision));
+        $("#home_lat").val(lat);
+        $("#home_lon").val(lon);
 
         deleted_lat = null;
         deleted_lon = null;
         respondToHomeUpdate();
+      }).on("moveend", function () {
+        const lat = $("#home_lat").val().trim(),
+              lon = $("#home_lon").val().trim();
+        let location;
+
+        try {
+          if (lat && lon) {
+            location = L.latLng(lat, lon);
+          }
+        } catch (error) {
+          // keep location undefined
+        }
+
+        $("#home_show").prop("disabled", !location || isCloseEnoughToMapCenter(location));
       });
 
       $("#home_lat, #home_lon").on("input", function () {
@@ -72,42 +95,62 @@ $(document).ready(function () {
       });
 
       $("#home_show").click(function () {
-        var lat = $("#home_lat").val(),
-            lon = $("#home_lon").val();
+        const lat = $("#home_lat").val(),
+              lon = $("#home_lon").val();
 
-        map.panTo([lat, lon]);
+        map.setView([lat, lon], defaultHomeZoom);
       });
 
       $("#home_delete").click(function () {
-        var lat = $("#home_lat").val(),
-            lon = $("#home_lon").val();
+        const lat = $("#home_lat").val(),
+              lon = $("#home_lon").val();
 
         $("#home_lat, #home_lon").val("");
         deleted_lat = lat;
         deleted_lon = lon;
         respondToHomeUpdate();
+        $("#home_undelete").trigger("focus");
+      });
+
+      $("#home_undelete").click(function () {
+        $("#home_lat").val(deleted_lat);
+        $("#home_lon").val(deleted_lon);
+        deleted_lat = null;
+        deleted_lon = null;
+        respondToHomeUpdate();
+        $("#home_delete").trigger("focus");
       });
     } else {
       $("[data-user]").each(function () {
-        var user = $(this).data("user");
+        const user = $(this).data("user");
         if (user.lon && user.lat) {
           L.marker([user.lat, user.lon], { icon: OSM.getUserIcon(user.icon) }).addTo(map)
-            .bindPopup(user.description);
+            .bindPopup(user.description, { minWidth: 200 });
         }
       });
     }
   }
 
   function respondToHomeUpdate() {
-    var lat = $("#home_lat").val(),
-        lon = $("#home_lon").val(),
-        has_home = !!(lat && lon);
-
-    $("#home_message").toggleClass("invisible", has_home);
-    $("#home_show").prop("hidden", !has_home);
-    $("#home_delete").prop("hidden", !has_home);
-    $("#home_undelete").prop("hidden", !(!has_home && deleted_lat && deleted_lon));
-    if (has_home) {
+    const lat = $("#home_lat").val().trim(),
+          lon = $("#home_lon").val().trim();
+    let location;
+
+    try {
+      if (lat && lon) {
+        location = L.latLng(lat, lon);
+      }
+      $("#home_lat, #home_lon").removeClass("is-invalid");
+    } catch (error) {
+      if (lat && isNaN(lat)) $("#home_lat").addClass("is-invalid");
+      if (lon && isNaN(lon)) $("#home_lon").addClass("is-invalid");
+    }
+
+    $("#home_message").toggleClass("invisible", Boolean(location));
+    $("#home_show").prop("hidden", !location);
+    $("#home_delete").prop("hidden", !location);
+    $("#home_undelete").prop("hidden", !(!location && deleted_lat && deleted_lon));
+    if (location) {
       marker.setLatLng([lat, lon]);
       marker.addTo(map);
       map.panTo([lat, lon]);
@@ -116,8 +159,15 @@ $(document).ready(function () {
     }
   }
 
+  function isCloseEnoughToMapCenter(location) {
+    const inputPt = map.latLngToContainerPoint(location),
+          centerPt = map.latLngToContainerPoint(map.getCenter());
+
+    return centerPt.distanceTo(inputPt) < 10;
+  }
+
   function updateAuthUID() {
-    var provider = $("select#user_auth_provider").val();
+    const provider = $("select#user_auth_provider").val();
 
     if (provider === "openid") {
       $("input#user_auth_uid").show().prop("disabled", false);
@@ -154,17 +204,13 @@ $(document).ready(function () {
     enableAuth();
   }
 
-  $("#user_all").change(function () {
-    $("#user_list input[type=checkbox]").prop("checked", $("#user_all").prop("checked"));
-  });
-
   $("#content.user_confirm").each(function () {
     $(this).hide();
     $(this).find("#confirm").submit();
   });
 
   $("input[name=legale]").change(function () {
-    var url = $(this).data("url");
+    const url = $(this).data("url");
 
     $("#contributorTerms").html("<div class='spinner-border' role='status'><span class='visually-hidden'>" + I18n.t("browse.start_rjs.loading") + "</span></div>");
     $("#contributorTerms").load(url);