X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/dbd88d893f3c3fce9cafd666b94396988646d81f..c62b8b29d4f6a6c7f2b12539a690d0faa8a34b29:/test/controllers/issues_controller_test.rb

diff --git a/test/controllers/issues_controller_test.rb b/test/controllers/issues_controller_test.rb
index 9cf68c869..a988fc909 100644
--- a/test/controllers/issues_controller_test.rb
+++ b/test/controllers/issues_controller_test.rb
@@ -1,265 +1,232 @@
 require "test_helper"
 
-class IssuesControllerTest < ActionController::TestCase
-  fixtures :users, :user_roles, :issues
-
-  teardown do
-    # cleanup any emails set off by the test
-    ActionMailer::Base.deliveries.clear
-  end
-
-  def test_view_dashboard_without_auth
-    # Access issues_path without login
-    get :index
-    assert_response :redirect
+class IssuesControllerTest < ActionDispatch::IntegrationTest
+  def test_index
+    # Access issues list without login
+    get issues_path
     assert_redirected_to login_path(:referer => issues_path)
 
-    # Access issues_path as normal user
-    session[:user] = users(:normal_user).id
-    get :index
-    assert_response :redirect
-    assert_redirected_to root_path
-
-    # Access issues_path by admin
-    session[:user] = users(:administrator_user).id
-    get :index
-    # this is redirected because there are no issues?!
-    assert_response :redirect
-    assert_redirected_to issues_path
+    # Access issues list as normal user
+    session_for(create(:user))
+    get issues_path
+    assert_redirected_to :controller => :errors, :action => :forbidden
 
-    # Access issues_path by moderator
-    session[:user] = users(:moderator_user).id
-    get :index
-    # this is redirected because there are no issues?!
-    assert_response :redirect
-    assert_redirected_to issues_path
+    # Access issues list as administrator
+    session_for(create(:administrator_user))
+    get issues_path
+    assert_response :success
 
-    # clear session
-    session.delete(:user)
+    # Access issues list as moderator
+    session_for(create(:moderator_user))
+    get issues_path
+    assert_response :success
   end
 
-  def test_new_issue_without_login
-    # Test creation of a new issue and a new report without logging in
-    get :new, :reportable_id => 1, :reportable_type => "User", :reported_user_id => 1
-    assert_response :redirect
-    assert_redirected_to login_path(:referer => new_issue_path(:reportable_id => 1, :reportable_type => "User", :reported_user_id => 1))
-  end
+  def test_show_moderator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
 
-  def test_new_issue_after_login
-    # Test creation of a new issue and a new report
+    # Access issue without login
+    get issue_path(:id => issue)
+    assert_redirected_to login_path(:referer => issue_path(issue))
 
-    # Login
-    session[:user] = users(:normal_user).id
+    # Access issue as normal user
+    session_for(create(:user))
+    get issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
 
-    assert_equal Issue.count, 0
+    # Access issue as administrator
+    session_for(create(:administrator_user))
+    get issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
 
-    # Create an Issue and a report
-    get :new, :reportable_id => 1, :reportable_type => "User", :reported_user_id => 2
+    # Access issue as moderator
+    session_for(create(:moderator_user))
+    get issue_path(:id => issue)
     assert_response :success
-    assert_difference "Issue.count", 1 do
-      details = "Details of a report"
-      post :create,
-           :report => { :details => details },
-           :report_type => "[OFFENSIVE]",
-           :issue => { :reportable_id => 1, :reportable_type => "User", :reported_user_id => 2 }
-    end
-    assert_equal Issue.count, 1
-    assert_response :redirect
-    assert_redirected_to root_path
-
-    # clear session
-    session.delete(:user)
   end
 
-  def test_new_report_with_incomplete_details
-    # Test creation of a new issue and a new report
+  def test_show_administrator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
 
-    # Login
-    session[:user] = users(:normal_user).id
+    # Access issue without login
+    get issue_path(:id => issue)
+    assert_redirected_to login_path(:referer => issue_path(issue))
 
-    assert_equal Issue.count, 0
+    # Access issue as normal user
+    session_for(create(:user))
+    get issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
 
-    # Create an Issue and a report
-    get :new, :reportable_id => 1, :reportable_type => "User", :reported_user_id => 2
-    assert_response :success
-    assert_difference "Issue.count", 1 do
-      details = "Details of a report"
-      post :create,
-           :report => { :details => details },
-           :report_type => "[OFFENSIVE]",
-           :issue => { :reportable_id => 1, :reportable_type => "User", :reported_user_id => 2 }
-    end
-    assert_equal Issue.count, 1
-    assert_response :redirect
-    assert_redirected_to root_path
+    # Access issue as moderator
+    session_for(create(:moderator_user))
+    get issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
 
-    get :new, :reportable_id => 1, :reportable_type => "User", :reported_user_id => 2
+    # Access issue as administrator
+    session_for(create(:administrator_user))
+    get issue_path(:id => issue)
     assert_response :success
-
-    # Report without report_type
-    assert_no_difference "Issue.count" do
-      details = "Details of another report under the same issue"
-      post :create,
-           :report => { :details => details },
-           :issue => { :reportable_id => 1, :reportable_type => "User", :reported_user_id => 2 }
-    end
-    assert_response :redirect
-    assert_equal Issue.find_by_reportable_id_and_reportable_type(1, "User").reports.count, 1
-
-    # Report without details
-    assert_no_difference "Issue.count" do
-      post :create,
-           :report_type => "[OFFENSIVE]",
-           :issue => { :reportable_id => 1, :reportable_type => "User", :reported_user_id => 2 }
-    end
-    assert_response :redirect
-    assert_equal Issue.find_by_reportable_id_and_reportable_type(1, "User").reports.count, 1
-
-    # clear session
-    session.delete(:user)
   end
 
-  def test_new_report_with_complete_details
-    # Test creation of a new issue and a new report
+  def test_resolve_moderator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
 
-    # Login
-    session[:user] = users(:normal_user).id
+    # Resolve issue without login
+    post resolve_issue_path(:id => issue)
+    assert_response :forbidden
 
-    assert_equal Issue.count, 0
+    # Resolve issue as normal user
+    session_for(create(:user))
+    post resolve_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
 
-    # Create an Issue and a report
-    get :new, :reportable_id => 1, :reportable_type => "User", :reported_user_id => 2
-    assert_response :success
-    assert_difference "Issue.count", 1 do
-      details = "Details of a report"
-      post :create,
-           :report => { :details => details },
-           :report_type => "[OFFENSIVE]",
-           :issue => { :reportable_id => 1, :reportable_type => "User", :reported_user_id => 2 }
-    end
-    assert_equal Issue.count, 1
-    assert_response :redirect
-    assert_redirected_to root_path
+    # Resolve issue as administrator
+    session_for(create(:administrator_user))
+    post resolve_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.resolved?
 
-    # Create a report for an existing Issue
-    get :new, :reportable_id => 1, :reportable_type => "User", :reported_user_id => 2
-    assert_response :success
-    assert_no_difference "Issue.count" do
-      details = "Details of another report under the same issue"
-      post :create,
-           :report => { :details => details },
-           :report_type => "[OFFENSIVE]",
-           :issue => { :reportable_id => 1, :reportable_type => "User", :reported_user_id => 2 }
-    end
+    # Resolve issue as moderator
+    session_for(create(:moderator_user))
+    post resolve_issue_path(:id => issue)
     assert_response :redirect
-    report_count = Issue.find_by_reportable_id_and_reportable_type(1, "User").reports.count
-    assert_equal report_count, 2
-
-    # clear session
-    session.delete(:user)
+    assert_predicate issue.reload, :resolved?
   end
 
-  def test_change_status_by_normal_user
-    # Login as normal user
-    session[:user] = users(:normal_user).id
+  def test_resolve_administrator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
 
-    # Create Issue
-    test_new_issue_after_login
-    assert_equal Issue.count, 1
+    # Resolve issue without login
+    post resolve_issue_path(:id => issue)
+    assert_response :forbidden
 
-    get :resolve, :id => Issue.find_by_reportable_id_and_reportable_type(1, "User").id
+    # Resolve issue as normal user
+    session_for(create(:user))
+    post resolve_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
 
-    assert_response :redirect
-    assert_redirected_to root_path
+    # Resolve issue as moderator
+    session_for(create(:moderator_user))
+    post resolve_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.resolved?
 
-    # clear session
-    session.delete(:user)
+    # Resolve issue as administrator
+    session_for(create(:administrator_user))
+    post resolve_issue_path(:id => issue)
+    assert_response :redirect
+    assert_predicate issue.reload, :resolved?
   end
 
-  def test_change_status_by_admin
-    # Login as normal user
-    session[:user] = users(:normal_user).id
+  def test_ignore_moderator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
 
-    # Create Issue
-    test_new_issue_after_login
-    assert_equal Issue.count, 1
-    assert_response :redirect
+    # Ignore issue without login
+    post ignore_issue_path(:id => issue)
+    assert_response :forbidden
 
-    # Login as administrator
-    session[:user] = users(:administrator_user).id
+    # Ignore issue as normal user
+    session_for(create(:user))
+    post ignore_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
 
-    # Test 'Resolved'
-    get :resolve, :id => Issue.find_by_reportable_id_and_reportable_type(1, "User").id
-    assert_equal Issue.find_by_reportable_id_and_reportable_type(1, "User").resolved?, true
-    assert_response :redirect
+    # Ignore issue as administrator
+    session_for(create(:administrator_user))
+    post ignore_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.ignored?
 
-    # Test 'Reopen'
-    get :reopen, :id => Issue.find_by_reportable_id_and_reportable_type(1, "User").id
-    assert_equal Issue.find_by_reportable_id_and_reportable_type(1, "User").open?, true
+    # Ignore issue as moderator
+    session_for(create(:moderator_user))
+    post ignore_issue_path(:id => issue)
     assert_response :redirect
+    assert_predicate issue.reload, :ignored?
+  end
 
-    # Test 'Ignored'
-    get :ignore, :id => Issue.find_by_reportable_id_and_reportable_type(1, "User").id
-    assert_equal Issue.find_by_reportable_id_and_reportable_type(1, "User").ignored?, true
-    assert_response :redirect
+  def test_ignore_administrator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
 
-    # clear session
-    session.delete(:user)
-  end
+    # Ignore issue without login
+    post ignore_issue_path(:id => issue)
+    assert_response :forbidden
 
-  def test_search_issues
-    # Login as administrator
-    session[:user] = users(:administrator_user).id
+    # Ignore issue as normal user
+    session_for(create(:user))
+    post ignore_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
 
-    # No issues against the user
-    get :index, :search_by_user => "test1"
-    assert_response :redirect
-    assert_redirected_to issues_path
+    # Ignore issue as moderator
+    session_for(create(:moderator_user))
+    post ignore_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.ignored?
 
-    # User doesn't exist
-    get :index, :search_by_user => "test1000"
+    # Ignore issue as administrator
+    session_for(create(:administrator_user))
+    post ignore_issue_path(:id => issue)
     assert_response :redirect
-    assert_redirected_to issues_path
+    assert_predicate issue.reload, :ignored?
+  end
 
-    # Create Issue against user_id:2
-    test_new_issue_after_login
-    assert_equal Issue.count, 1
-    assert_equal Issue.first.reported_user_id, 2
+  def test_reopen_moderator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator")
 
-    session[:user] = users(:administrator_user).id
+    issue.resolve!
 
-    # Find Issue against user_id:2
-    get :index, :search_by_user => "test2"
-    assert_response :success
+    # Reopen issue without login
+    post reopen_issue_path(:id => issue)
+    assert_response :forbidden
 
-    # clear session
-    session.delete(:user)
-  end
+    # Reopen issue as normal user
+    session_for(create(:user))
+    post reopen_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
 
-  def test_comment_by_normal_user
-    # Create Issue
-    test_new_issue_after_login
-    assert_equal Issue.count, 1
+    # Reopen issue as administrator
+    session_for(create(:administrator_user))
+    post reopen_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.open?
 
-    get :comment, :id => 1
+    # Reopen issue as moderator
+    session_for(create(:moderator_user))
+    post reopen_issue_path(:id => issue)
     assert_response :redirect
-    assert_redirected_to root_path
+    assert_predicate issue.reload, :open?
   end
 
-  def test_comment
-    # Create Issue
-    test_new_issue_after_login
-    assert_equal Issue.count, 1
-    @issue = Issue.all.first
+  def test_reopen_administrator
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator")
 
-    # Login as administrator
-    session[:user] = users(:administrator_user).id
+    issue.resolve!
 
-    get :comment, :id => @issue.id, :issue_comment => { :body => "test comment" }
-    assert_response :redirect
-    assert_redirected_to @issue
+    # Reopen issue without login
+    post reopen_issue_path(:id => issue)
+    assert_response :forbidden
+
+    # Reopen issue as normal user
+    session_for(create(:user))
+    post reopen_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :forbidden
 
-    # clear session
-    session.delete(:user)
+    # Reopen issue as moderator
+    session_for(create(:moderator_user))
+    post reopen_issue_path(:id => issue)
+    assert_redirected_to :controller => :errors, :action => :not_found
+    assert_not issue.reload.open?
+
+    # Reopen issue as administrator
+    session_for(create(:administrator_user))
+    post reopen_issue_path(:id => issue)
+    assert_response :redirect
+    assert_predicate issue.reload, :open?
   end
 end