X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/dbe165bbb3d6eda37d9579f1ac767599f9055607..99c54bc5b6c06f9457d45cdd42bd078b20ffb779:/.rubocop_todo.yml?ds=inline diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 57b992971..b4104079c 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,126 +1,229 @@ -# This configuration was generated by `rubocop --auto-gen-config` -# on 2015-02-25 00:27:05 +0000 using RuboCop version 0.29.1. +# This configuration was generated by +# `rubocop --auto-gen-config` +# on 2017-10-05 10:04:24 +0100 using RuboCop version 0.50.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 13 +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. +# SupportedStyles: aligned, indented +Layout/MultilineOperationIndentation: + Exclude: + - 'lib/bounding_box.rb' + +# Offense count: 34 Lint/AmbiguousOperator: - Enabled: false + Exclude: + - 'test/controllers/amf_controller_test.rb' + - 'test/controllers/changeset_controller_test.rb' + - 'test/lib/bounding_box_test.rb' + - 'test/lib/country_test.rb' -# Offense count: 107 +# Offense count: 124 Lint/AmbiguousRegexpLiteral: Enabled: false -# Offense count: 29 +# Offense count: 32 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: - Enabled: false + Exclude: + - 'app/controllers/application_controller.rb' + - 'app/controllers/geocoder_controller.rb' + - 'app/controllers/notes_controller.rb' + - 'app/controllers/trace_controller.rb' + - 'app/controllers/user_controller.rb' + - 'app/controllers/user_preference_controller.rb' + - 'app/helpers/application_helper.rb' + - 'app/helpers/browse_helper.rb' + - 'app/models/client_application.rb' + - 'app/models/notifier.rb' + - 'lib/nominatim.rb' + - 'lib/osm.rb' + - 'script/deliver-message' -# Offense count: 5 +# Offense count: 4 Lint/HandleExceptions: - Enabled: false + Exclude: + - 'app/controllers/amf_controller.rb' + - 'app/controllers/user_controller.rb' -# Offense count: 8 -Lint/ParenthesesAsGroupedExpression: - Enabled: false +# Offense count: 3 +Lint/InterpolationCheck: + Exclude: + - 'test/controllers/node_controller_test.rb' + +# Offense count: 2 +Lint/RescueWithoutErrorClass: + Exclude: + - 'app/helpers/browse_helper.rb' + +# Offense count: 2 +Lint/ShadowingOuterLocalVariable: + Exclude: + - 'app/views/changeset/list.atom.builder' -# Offense count: 542 +# Offense count: 666 Metrics/AbcSize: - Max: 194 + Max: 280 + +# Offense count: 41 +# Configuration parameters: CountComments, ExcludedMethods. +Metrics/BlockLength: + Max: 240 # Offense count: 12 +# Configuration parameters: CountBlocks. Metrics/BlockNesting: Max: 5 -# Offense count: 60 +# Offense count: 63 # Configuration parameters: CountComments. Metrics/ClassLength: - Max: 1515 + Max: 1796 -# Offense count: 68 +# Offense count: 71 Metrics/CyclomaticComplexity: - Max: 21 + Max: 20 -# Offense count: 2092 -# Configuration parameters: AllowURI, URISchemes. +# Offense count: 3004 +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# URISchemes: http, https Metrics/LineLength: - Max: 520 + Max: 1073 -# Offense count: 520 +# Offense count: 675 # Configuration parameters: CountComments. Metrics/MethodLength: Max: 179 +# Offense count: 2 +# Configuration parameters: CountComments. +Metrics/ModuleLength: + Max: 147 + # Offense count: 4 # Configuration parameters: CountKeywordArgs. Metrics/ParameterLists: Max: 9 -# Offense count: 70 +# Offense count: 71 Metrics/PerceivedComplexity: - Max: 24 + Max: 23 + +# Offense count: 5 +Naming/AccessorMethodName: + Exclude: + - 'app/controllers/application_controller.rb' + - 'app/helpers/title_helper.rb' + - 'app/models/old_way.rb' + - 'lib/osm.rb' + - 'lib/potlatch.rb' + +# Offense count: 8 +# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist. +# NamePrefix: is_, has_, have_ +# NamePrefixBlacklist: is_, has_, have_ +# NameWhitelist: is_a? +Naming/PredicateName: + Exclude: + - 'spec/**/*' + - 'app/models/changeset.rb' + - 'app/models/old_node.rb' + - 'app/models/old_relation.rb' + - 'app/models/old_way.rb' + - 'app/models/user.rb' + - 'lib/classic_pagination/pagination.rb' + +# Offense count: 2 +# Configuration parameters: Include. +# Include: app/**/*.rb, config/**/*.rb, lib/**/*.rb +Rails/Exit: + Exclude: + - 'lib/**/*.rake' + - 'lib/daemons/gpx_import.rb' # Offense count: 2 # Configuration parameters: Include. +# Include: app/models/**/*.rb Rails/HasAndBelongsToMany: - Enabled: false + Exclude: + - 'app/models/changeset.rb' + - 'app/models/user.rb' # Offense count: 5 -Style/AccessorMethodName: +# Configuration parameters: Include. +# Include: db/migrate/*.rb +Rails/NotNullColumn: + Exclude: + - 'db/migrate/002_cleanup_osm_db.rb' + - 'db/migrate/020_populate_node_tags_and_remove.rb' + - 'db/migrate/021_move_to_innodb.rb' + - 'db/migrate/025_add_end_time_to_changesets.rb' + - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' + +# Offense count: 20 +Rails/OutputSafety: + Exclude: + - 'app/controllers/user_controller.rb' + - 'app/helpers/application_helper.rb' + - 'app/helpers/changeset_helper.rb' + - 'app/helpers/geocoder_helper.rb' + - 'app/helpers/note_helper.rb' + - 'app/helpers/open_graph_helper.rb' + - 'app/helpers/user_blocks_helper.rb' + - 'app/helpers/user_roles_helper.rb' + - 'lib/rich_text.rb' + - 'test/helpers/application_helper_test.rb' + +# Offense count: 86 +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: strict, flexible +Rails/TimeZone: Enabled: false # Offense count: 1 Style/AsciiComments: - Enabled: false + Exclude: + - 'test/models/message_test.rb' -# Offense count: 305 +# Offense count: 219 Style/Documentation: Enabled: false -# Offense count: 39 -# Configuration parameters: MinBodyLength. -Style/GuardClause: - Enabled: false +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: MaxLineLength. +Style/IfUnlessModifier: + Exclude: + - 'app/controllers/way_controller.rb' # Offense count: 60 # Cop supports --auto-correct. Style/LineEndConcatenation: - Enabled: false - -# Offense count: 53 + Exclude: + - 'db/migrate/008_remove_segments.rb' + - 'db/migrate/020_populate_node_tags_and_remove.rb' + - 'db/migrate/023_add_changesets.rb' + - 'lib/bounding_box.rb' + - 'lib/diff_reader.rb' + - 'lib/osm.rb' + - 'test/controllers/changeset_controller_test.rb' + - 'test/controllers/node_controller_test.rb' + - 'test/controllers/relation_controller_test.rb' + - 'test/controllers/way_controller_test.rb' + +# Offense count: 75 # Cop supports --auto-correct. +# Configuration parameters: Strict. Style/NumericLiterals: MinDigits: 11 -# Offense count: 44 -# Cop supports --auto-correct. -Style/PerlBackrefs: - Enabled: false - -# Offense count: 8 -# Configuration parameters: NamePrefix, NamePrefixBlacklist. -Style/PredicateName: - Enabled: false - # Offense count: 95 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/RaiseArgs: - Enabled: false - -# Offense count: 2 -Style/RescueModifier: - Enabled: false - -# Offense count: 8 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. -Style/StringLiteralsInInterpolation: - Enabled: false - -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, Whitelist. -Style/TrivialAccessors: +# SupportedStyles: compact, exploded +Style/RaiseArgs: Enabled: false