X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/dc2a2c8ebd1a11e4a64555fda22c6859a51defff..6f375ef4936ea6e92e84b1473940af7883fba4d6:/app/controllers/old_controller.rb diff --git a/app/controllers/old_controller.rb b/app/controllers/old_controller.rb index ff86407f5..16f1083de 100644 --- a/app/controllers/old_controller.rb +++ b/app/controllers/old_controller.rb @@ -4,23 +4,22 @@ class OldController < ApplicationController require "xml/libxml" - skip_before_filter :verify_authenticity_token - before_filter :setup_user_auth, :only => [:history, :version] - before_filter :authorize, :only => [:redact] - before_filter :authorize_moderator, :only => [:redact] - before_filter :require_allow_write_api, :only => [:redact] - before_filter :check_api_readable - before_filter :check_api_writable, :only => [:redact] - after_filter :compress_output - around_filter :api_call_handle_error, :api_call_timeout - before_filter :lookup_old_element, :except => [:history] - before_filter :lookup_old_element_versions, :only => [:history] + skip_before_action :verify_authenticity_token + before_action :setup_user_auth, :only => [:history, :version] + before_action :authorize, :only => [:redact] + before_action :authorize_moderator, :only => [:redact] + before_action :require_allow_write_api, :only => [:redact] + before_action :check_api_readable + before_action :check_api_writable, :only => [:redact] + around_action :api_call_handle_error, :api_call_timeout + before_action :lookup_old_element, :except => [:history] + before_action :lookup_old_element_versions, :only => [:history] def history # the .where() method used in the lookup_old_element_versions # call won't throw an error if no records are found, so we have # to do that ourselves. - fail OSM::APINotFoundError.new if @elements.empty? + raise OSM::APINotFoundError.new if @elements.empty? doc = OSM::API.new.get_xml_doc @@ -34,12 +33,12 @@ class OldController < ApplicationController doc.root << element.to_xml_node end - render :text => doc.to_s, :content_type => "text/xml" + render :xml => doc.to_s end def version if @old_element.redacted? && !show_redactions? - render :text => "", :status => :forbidden + head :forbidden else response.last_modified = @old_element.timestamp @@ -47,7 +46,7 @@ class OldController < ApplicationController doc = OSM::API.new.get_xml_doc doc.root << @old_element.to_xml_node - render :text => doc.to_s, :content_type => "text/xml" + render :xml => doc.to_s end end @@ -65,7 +64,7 @@ class OldController < ApplicationController end # just return an empty 200 OK for success - render :text => "" + head :ok end private