X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/dc2a2c8ebd1a11e4a64555fda22c6859a51defff..f3b6e0faa1cbf92b46555bea2fca62ca1895e703:/test/controllers/redactions_controller_test.rb?ds=inline diff --git a/test/controllers/redactions_controller_test.rb b/test/controllers/redactions_controller_test.rb index 7e9170a2c..73061ed57 100644 --- a/test/controllers/redactions_controller_test.rb +++ b/test/controllers/redactions_controller_test.rb @@ -2,8 +2,6 @@ require "test_helper" require "redactions_controller" class RedactionsControllerTest < ActionController::TestCase - api_fixtures - ## # test all routes which lead to this controller def test_routes @@ -37,85 +35,142 @@ class RedactionsControllerTest < ActionController::TestCase ) end - def test_moderators_can_create - session[:user] = users(:moderator_user).id + def test_index + create(:redaction) + + get :index + assert_response :success + assert_template :index + assert_select "ul#redaction_list", 1 do + assert_select "li", Redaction.count + end + end - post :create, :redaction => { :title => "Foo", :description => "Description here." } + def test_new + get :new assert_response :redirect - assert_redirected_to(redaction_path(Redaction.find_by_title("Foo"))) + assert_redirected_to login_path(:referer => new_redaction_path) + end + + def test_new_moderator + session[:user] = create(:moderator_user).id + + get :new + assert_response :success + assert_template :new end - def test_non_moderators_cant_create - session[:user] = users(:public_user).id + def test_new_non_moderator + session[:user] = create(:user).id + + get :new + assert_response :redirect + assert_redirected_to redactions_path + end + + def test_create_moderator + session[:user] = create(:moderator_user).id + + post :create, :params => { :redaction => { :title => "Foo", :description => "Description here." } } + assert_response :redirect + assert_redirected_to(redaction_path(Redaction.find_by(:title => "Foo"))) + end - post :create, :redaction => { :title => "Foo", :description => "Description here." } + def test_create_moderator_invalid + session[:user] = create(:moderator_user).id + + post :create, :params => { :redaction => { :title => "Foo", :description => "" } } + assert_response :success + assert_template :new + end + + def test_create_non_moderator + session[:user] = create(:user).id + + post :create, :params => { :redaction => { :title => "Foo", :description => "Description here." } } assert_response :forbidden end - def test_moderators_can_delete_empty - session[:user] = users(:moderator_user).id + def test_destroy_moderator_empty + session[:user] = create(:moderator_user).id - # remove all elements from the redaction - redaction = redactions(:example) - redaction.old_nodes.each { |n| n.update!(:redaction => nil) } - redaction.old_ways.each { |w| w.update!(:redaction => nil) } - redaction.old_relations.each { |r| r.update!(:redaction => nil) } + # create an empty redaction + redaction = create(:redaction) - delete :destroy, :id => redaction.id + delete :destroy, :params => { :id => redaction.id } assert_response :redirect assert_redirected_to(redactions_path) end - def test_moderators_cant_delete_nonempty - session[:user] = users(:moderator_user).id + def test_destroy_moderator_non_empty + session[:user] = create(:moderator_user).id - # leave elements in the redaction - redaction = redactions(:example) + # create elements in the redaction + redaction = create(:redaction) + create(:old_node, :redaction => redaction) - delete :destroy, :id => redaction.id + delete :destroy, :params => { :id => redaction.id } assert_response :redirect assert_redirected_to(redaction_path(redaction)) assert_match /^Redaction is not empty/, flash[:error] end - def test_non_moderators_cant_delete - session[:user] = users(:public_user).id + def test_delete_non_moderator + session[:user] = create(:user).id - delete :destroy, :id => redactions(:example).id + delete :destroy, :params => { :id => create(:redaction).id } assert_response :forbidden end - def test_moderators_can_edit - session[:user] = users(:moderator_user).id + def test_edit + redaction = create(:redaction) + + get :edit, :params => { :id => redaction.id } + assert_response :redirect + assert_redirected_to login_path(:referer => edit_redaction_path(redaction)) + end + + def test_edit_moderator + session[:user] = create(:moderator_user).id - get :edit, :id => redactions(:example).id + get :edit, :params => { :id => create(:redaction).id } assert_response :success end - def test_non_moderators_cant_edit - session[:user] = users(:public_user).id + def test_edit_non_moderator + session[:user] = create(:user).id - get :edit, :id => redactions(:example).id + get :edit, :params => { :id => create(:redaction).id } assert_response :redirect assert_redirected_to(redactions_path) end - def test_moderators_can_update - session[:user] = users(:moderator_user).id + def test_update_moderator + session[:user] = create(:moderator_user).id - redaction = redactions(:example) + redaction = create(:redaction) - put :update, :id => redaction.id, :redaction => { :title => "Foo", :description => "Description here." } + put :update, :params => { :id => redaction.id, :redaction => { :title => "Foo", :description => "Description here." } } assert_response :redirect assert_redirected_to(redaction_path(redaction)) end - def test_non_moderators_cant_update - session[:user] = users(:public_user).id + def test_update_moderator_invalid + session[:user] = create(:moderator_user).id + + redaction = create(:redaction) + + put :update, :params => { :id => redaction.id, :redaction => { :title => "Foo", :description => "" } } + assert_response :success + assert_template :edit + end + + def test_updated_non_moderator + session[:user] = create(:user).id - redaction = redactions(:example) + redaction = create(:redaction) - put :update, :id => redaction.id, :redaction => { :title => "Foo", :description => "Description here." } + put :update, :params => { :id => redaction.id, :redaction => { :title => "Foo", :description => "Description here." } } assert_response :forbidden end end