X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/de78176e04961c52f1fa1283812ec06ce6eb90cf..16a0f14f4aa3cad2d38fe35d61afa1f6a236302b:/app/assets/javascripts/index/notes.js.erb

diff --git a/app/assets/javascripts/index/notes.js.erb b/app/assets/javascripts/index/notes.js.erb
index 876aeb193..4e9b50254 100644
--- a/app/assets/javascripts/index/notes.js.erb
+++ b/app/assets/javascripts/index/notes.js.erb
@@ -61,38 +61,59 @@ $(document).ready(function () {
         opacity: 0.7
       });
 
-      marker.addTo(noteLayer).bindPopup(popupContent);
+      marker.addTo(noteLayer).bindPopup(popupContent, popupOptions());
     }
 
     return marker;
   }
 
+  var noteLoader;
+
   function loadNotes() {
     var bounds = map.getBounds();
-    var url = "/api/" + OSM.API_VERSION + "/notes.json?bbox=" + bounds.toBBOX();
+    var size = bounds.getSize();
 
-    $.ajax({
-      url: url,
-      success: function (json) {
-        var oldNotes = notes;
+    if (size <= OSM.MAX_NOTE_REQUEST_AREA) {
+      var url = "/api/" + OSM.API_VERSION + "/notes.json?bbox=" + bounds.toBBOX();
+
+      if (noteLoader) noteLoader.abort();
 
-        notes = {};
+      noteLoader = $.ajax({
+        url: url,
+        success: function (json) {
+          var oldNotes = notes;
 
-        json.features.forEach(function (feature) {
-          var marker = oldNotes[feature.properties.id];
+          notes = {};
 
-          delete oldNotes[feature.properties.id];
+          json.features.forEach(function (feature) {
+            var marker = oldNotes[feature.properties.id];
 
-          notes[feature.properties.id] = updateMarker(marker, feature);
-        });
+            delete oldNotes[feature.properties.id];
 
-        for (id in oldNotes) {
-          noteLayer.removeLayer(oldNotes[id]);
+            notes[feature.properties.id] = updateMarker(marker, feature);
+          });
+
+          for (id in oldNotes) {
+            noteLayer.removeLayer(oldNotes[id]);
+          }
+
+          noteLoader = null;
         }
-      }
-    });
+      });
+    }
   };
 
+  function popupOptions() {
+    var mapSize = map.getSize();
+
+    return { 
+      minWidth: 320,
+      maxWidth: mapSize.y * 1 / 3, 
+      maxHeight: mapSize.y * 2 / 3, 
+      autoPanPadding: new L.Point(60, 40)
+    };
+  }
+
   function createPopupContent(marker, properties) {
     var content = $(JST["templates/notes/show"]({ note: properties }));
 
@@ -158,6 +179,8 @@ $(document).ready(function () {
   $("#createnoteanchor").click(function (e) {
     e.preventDefault();
 
+    if ($(e.target).hasClass("disabled")) return;
+
     map.addLayer(noteLayer);
 
     var marker = L.marker(map.getCenter(), {
@@ -173,7 +196,7 @@ $(document).ready(function () {
       createNote(marker, e.target.form, $(e.target).data("url"));
     });
 
-    marker.addTo(noteLayer).bindPopup(popupContent[0]).openPopup();
+    marker.addTo(noteLayer).bindPopup(popupContent[0], popupOptions()).openPopup();
 
     $(".leaflet-popup-close-button").on("click.close", function (e) {
       map.removeLayer(marker);