X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/e1f79d84adc413afa2a1a8d8d06fda9fa5151d49..ac3df158f752ffc172a22fc30a7a94b58e74c493:/.rubocop_todo.yml?ds=sidebyside diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index ac10d78c9..06a9c76f0 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,680 +1,220 @@ -# This configuration was generated by `rubocop --auto-gen-config` -# on 2015-02-16 18:44:13 +0000 using RuboCop version 0.29.1. +# This configuration was generated by +# `rubocop --auto-gen-config` +# on 2019-10-19 16:05:52 +0000 using RuboCop version 0.75.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 13 -Lint/AmbiguousOperator: - Enabled: false +# Work around erblint issues. +# https://github.com/openstreetmap/openstreetmap-website/issues/2472 +require: + - rubocop-performance + - rubocop-rails -# Offense count: 110 -Lint/AmbiguousRegexpLiteral: - Enabled: false +# Offense count: 3338 +# Cop supports --auto-correct. +# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# URISchemes: http, https +Layout/LineLength: + Max: 260 -# Offense count: 29 +# Offense count: 35 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: - Enabled: false - -# Offense count: 4 -# Cop supports --auto-correct. -Lint/BlockAlignment: - Enabled: false - -# Offense count: 1 -# Configuration parameters: AlignWith, SupportedStyles. -Lint/DefEndAlignment: - Enabled: false + Exclude: + - 'app/controllers/api/traces_controller.rb' + - 'app/controllers/api/user_preferences_controller.rb' + - 'app/controllers/application_controller.rb' + - 'app/controllers/geocoder_controller.rb' + - 'app/controllers/notes_controller.rb' + - 'app/controllers/traces_controller.rb' + - 'app/controllers/users_controller.rb' + - 'app/helpers/application_helper.rb' + - 'app/helpers/browse_tags_helper.rb' + - 'app/mailers/notifier.rb' + - 'app/models/client_application.rb' + - 'lib/nominatim.rb' + - 'lib/osm.rb' + - 'script/deliver-message' # Offense count: 4 -# Cop supports --auto-correct. -Lint/DeprecatedClassMethods: - Enabled: false - -# Offense count: 2 -Lint/DuplicateMethods: - Enabled: false - -# Offense count: 5 -# Configuration parameters: AlignWith, SupportedStyles. -Lint/EndAlignment: - Enabled: false - -# Offense count: 8 -Lint/HandleExceptions: - Enabled: false - -# Offense count: 1 -Lint/LiteralInCondition: - Enabled: false - -# Offense count: 8 -Lint/ParenthesesAsGroupedExpression: - Enabled: false - -# Offense count: 18 -Lint/RescueException: - Enabled: false - -# Offense count: 3 -Lint/ShadowingOuterLocalVariable: - Enabled: false - -# Offense count: 9 -# Cop supports --auto-correct. -Lint/SpaceBeforeFirstArg: - Enabled: false - -# Offense count: 21 -# Cop supports --auto-correct. -Lint/StringConversionInInterpolation: - Enabled: false - -# Offense count: 17 -# Cop supports --auto-correct. -Lint/UnusedBlockArgument: - Enabled: false - -# Offense count: 16 -# Cop supports --auto-correct. -Lint/UnusedMethodArgument: - Enabled: false - -# Offense count: 2 -Lint/UselessAccessModifier: - Enabled: false - -# Offense count: 48 -Lint/UselessAssignment: - Enabled: false - -# Offense count: 2 -Lint/Void: - Enabled: false - -# Offense count: 546 +# Configuration parameters: AllowComments. +Lint/SuppressedException: + Exclude: + - 'app/controllers/api/amf_controller.rb' + - 'app/controllers/users_controller.rb' + - 'app/controllers/site_controller.rb' + +# Offense count: 701 Metrics/AbcSize: - Max: 194 + Max: 189 + +# Offense count: 39 +# Configuration parameters: CountComments, ExcludedMethods. +# ExcludedMethods: refine +Metrics/BlockLength: + Max: 71 -# Offense count: 12 +# Offense count: 15 +# Configuration parameters: CountBlocks. Metrics/BlockNesting: Max: 5 -# Offense count: 60 +# Offense count: 25 # Configuration parameters: CountComments. Metrics/ClassLength: - Max: 1515 + Max: 645 -# Offense count: 68 +# Offense count: 74 Metrics/CyclomaticComplexity: - Max: 21 - -# Offense count: 2076 -# Configuration parameters: AllowURI, URISchemes. -Metrics/LineLength: - Max: 253 + Max: 22 -# Offense count: 520 -# Configuration parameters: CountComments. +# Offense count: 722 +# Configuration parameters: CountComments, ExcludedMethods. Metrics/MethodLength: Max: 179 +# Offense count: 2 +# Configuration parameters: CountComments. +Metrics/ModuleLength: + Max: 117 + # Offense count: 4 # Configuration parameters: CountKeywordArgs. Metrics/ParameterLists: Max: 9 -# Offense count: 70 +# Offense count: 72 Metrics/PerceivedComplexity: - Max: 24 - -# Offense count: 46 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/AccessModifierIndentation: - Enabled: false - -# Offense count: 5 -Style/AccessorMethodName: - Enabled: false + Max: 25 # Offense count: 6 -# Cop supports --auto-correct. -Style/Alias: - Enabled: false - -# Offense count: 9 -# Cop supports --auto-correct. -Style/AlignArray: - Enabled: false - -# Offense count: 6 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle, SupportedLastArgumentHashStyles. -Style/AlignHash: - Enabled: false - -# Offense count: 159 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/AlignParameters: - Enabled: false - -# Offense count: 217 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/AndOr: - Enabled: false - -# Offense count: 1 -Style/AsciiComments: - Enabled: false - -# Offense count: 87 -# Cop supports --auto-correct. -Style/Blocks: - Enabled: false - -# Offense count: 636 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/BracesAroundHashParameters: - Enabled: false - -# Offense count: 21 -# Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep. -Style/CaseIndentation: - Enabled: false - -# Offense count: 3 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/ClassAndModuleChildren: - Enabled: false - -# Offense count: 3 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/ClassCheck: - Enabled: false - -# Offense count: 9 -Style/ClassVars: - Enabled: false - -# Offense count: 12 -# Cop supports --auto-correct. -Style/ColonMethodCall: - Enabled: false - -# Offense count: 12 -# Configuration parameters: Keywords. -Style/CommentAnnotation: - Enabled: false - -# Offense count: 25 -# Cop supports --auto-correct. -Style/CommentIndentation: - Enabled: false - -# Offense count: 9 -Style/ConstantName: - Enabled: false - -# Offense count: 17 -# Cop supports --auto-correct. -Style/DeprecatedHashMethods: - Enabled: false - -# Offense count: 306 -Style/Documentation: - Enabled: false - -# Offense count: 14 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/DotPosition: - Enabled: false - -# Offense count: 2 -Style/EachWithObject: - Enabled: false - -# Offense count: 5 -# Cop supports --auto-correct. -Style/ElseAlignment: - Enabled: false - -# Offense count: 3 -Style/EmptyElse: - Enabled: false - -# Offense count: 8 -# Cop supports --auto-correct. -# Configuration parameters: AllowAdjacentOneLineDefs. -Style/EmptyLineBetweenDefs: - Enabled: false - -# Offense count: 16 -# Cop supports --auto-correct. -Style/EmptyLines: - Enabled: false - -# Offense count: 15 -# Cop supports --auto-correct. -Style/EmptyLinesAroundAccessModifier: - Enabled: false - -# Offense count: 9 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/EmptyLinesAroundBlockBody: - Enabled: false - -# Offense count: 28 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/EmptyLinesAroundClassBody: - Enabled: false - -# Offense count: 8 -# Cop supports --auto-correct. -Style/EmptyLinesAroundMethodBody: - Enabled: false +Naming/AccessorMethodName: + Exclude: + - 'app/controllers/application_controller.rb' + - 'app/helpers/title_helper.rb' + - 'app/models/old_way.rb' + - 'lib/osm.rb' + - 'lib/potlatch.rb' # Offense count: 8 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/EmptyLinesAroundModuleBody: - Enabled: false - -# Offense count: 45 -# Cop supports --auto-correct. -Style/EmptyLiteral: - Enabled: false - -# Offense count: 3 -# Configuration parameters: Exclude. -Style/FileName: - Enabled: false - -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/FirstParameterIndentation: - Enabled: false - -# Offense count: 3 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/For: - Enabled: false - -# Offense count: 8 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/FormatString: - Enabled: false - -# Offense count: 1 -# Configuration parameters: AllowedVariables. -Style/GlobalVars: - Enabled: false - -# Offense count: 41 -# Configuration parameters: MinBodyLength. -Style/GuardClause: - Enabled: false - -# Offense count: 5687 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/HashSyntax: - Enabled: false - -# Offense count: 42 -# Configuration parameters: MaxLineLength. -Style/IfUnlessModifier: - Enabled: false - -# Offense count: 18 -# Cop supports --auto-correct. -Style/IndentArray: - Enabled: false - -# Offense count: 15 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/IndentHash: - Enabled: false +# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros. +# NamePrefix: is_, has_, have_ +# NamePrefixBlacklist: is_, has_, have_ +# NameWhitelist: is_a? +# MethodDefinitionMacros: define_method, define_singleton_method +Naming/PredicateName: + Exclude: + - 'spec/**/*' + - 'app/models/changeset.rb' + - 'app/models/old_node.rb' + - 'app/models/old_relation.rb' + - 'app/models/old_way.rb' + - 'app/models/user.rb' + - 'lib/classic_pagination/pagination.rb' -# Offense count: 22 -# Cop supports --auto-correct. -Style/IndentationConsistency: - Enabled: false - -# Offense count: 40 -# Cop supports --auto-correct. -# Configuration parameters: Width. -Style/IndentationWidth: - Enabled: false - -# Offense count: 67 -# Cop supports --auto-correct. -Style/LeadingCommentSpace: - Enabled: false - -# Offense count: 74 -# Cop supports --auto-correct. -Style/LineEndConcatenation: - Enabled: false - -# Offense count: 17 -# Cop supports --auto-correct. -Style/MethodCallParentheses: - Enabled: false - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/MethodDefParentheses: - Enabled: false - -# Offense count: 12 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/MethodName: - Enabled: false - -# Offense count: 28 -# Cop supports --auto-correct. -Style/MultilineIfThen: - Enabled: false - -# Offense count: 34 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/MultilineOperationIndentation: - Enabled: false - -# Offense count: 3 -Style/MultilineTernaryOperator: - Enabled: false - -# Offense count: 19 -# Cop supports --auto-correct. -Style/NegatedIf: - Enabled: false - -# Offense count: 1 -Style/NestedTernaryOperator: - Enabled: false - -# Offense count: 11 -# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles. -Style/Next: - Enabled: false - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: IncludeSemanticChanges. -Style/NonNilCheck: - Enabled: false - -# Offense count: 32 -# Cop supports --auto-correct. -Style/Not: - Enabled: false - -# Offense count: 53 +# Offense count: 5 # Cop supports --auto-correct. -Style/NumericLiterals: - MinDigits: 11 +Performance/RegexpMatch: + Exclude: + - 'app/helpers/browse_tags_helper.rb' + - 'app/validators/characters_validator.rb' + - 'app/validators/whitespace_validator.rb' -# Offense count: 42 -Style/OneLineConditional: - Enabled: false +# Offense count: 6 +# Configuration parameters: Database, Include. +# SupportedDatabases: mysql, postgresql +# Include: db/migrate/*.rb +Rails/BulkChangeTable: + Exclude: + - 'db/migrate/20111116184519_update_oauth.rb' + - 'db/migrate/20120208122334_merge_acl_address_and_mask.rb' + - 'db/migrate/20120208194454_add_domain_to_acl.rb' + - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' # Offense count: 2 -Style/OpMethod: - Enabled: false - -# Offense count: 7 -# Cop supports --auto-correct. -# Configuration parameters: AllowSafeAssignment. -Style/ParenthesesAroundCondition: - Enabled: false - -# Offense count: 21 -# Cop supports --auto-correct. -# Configuration parameters: PreferredDelimiters. -Style/PercentLiteralDelimiters: - Enabled: false - -# Offense count: 44 -# Cop supports --auto-correct. -Style/PerlBackrefs: - Enabled: false - -# Offense count: 8 -# Configuration parameters: NamePrefix, NamePrefixBlacklist. -Style/PredicateName: - Enabled: false - -# Offense count: 8 -# Cop supports --auto-correct. -Style/Proc: - Enabled: false - -# Offense count: 95 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/RaiseArgs: - Enabled: false +# Configuration parameters: Include. +# Include: app/models/**/*.rb +Rails/HasAndBelongsToMany: + Exclude: + - 'app/models/changeset.rb' + - 'app/models/user.rb' # Offense count: 11 -# Cop supports --auto-correct. -Style/RedundantBegin: - Enabled: false - -# Offense count: 113 -# Cop supports --auto-correct. -# Configuration parameters: AllowMultipleReturnValues. -Style/RedundantReturn: - Enabled: false - -# Offense count: 200 -# Cop supports --auto-correct. -Style/RedundantSelf: - Enabled: false - -# Offense count: 11 -Style/RegexpLiteral: - MaxSlashes: 5 - -# Offense count: 2 -Style/RescueModifier: - Enabled: false - -# Offense count: 7 -# Cop supports --auto-correct. -Style/SelfAssignment: - Enabled: false - -# Offense count: 60 -# Cop supports --auto-correct. -# Configuration parameters: AllowAsExpressionSeparator. -Style/Semicolon: - Enabled: false - -# Offense count: 156 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/SignalException: - Enabled: false - -# Offense count: 4 -# Configuration parameters: Methods. -Style/SingleLineBlockParams: - Enabled: false - -# Offense count: 3 -# Cop supports --auto-correct. -Style/SingleSpaceBeforeFirstArg: - Enabled: false - -# Offense count: 2 -# Cop supports --auto-correct. -Style/SpaceAfterColon: - Enabled: false - -# Offense count: 409 -# Cop supports --auto-correct. -Style/SpaceAfterComma: - Enabled: false - -# Offense count: 1 -# Cop supports --auto-correct. -Style/SpaceAfterControlKeyword: - Enabled: false - -# Offense count: 3 -# Cop supports --auto-correct. -Style/SpaceAfterMethodName: - Enabled: false - -# Offense count: 34 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/SpaceAroundEqualsInParameterDefault: - Enabled: false - -# Offense count: 493 -# Cop supports --auto-correct. -Style/SpaceAroundOperators: - Enabled: false - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/SpaceBeforeBlockBraces: - Enabled: false - -# Offense count: 13 -# Cop supports --auto-correct. -Style/SpaceBeforeComma: - Enabled: false - -# Offense count: 2 -# Cop supports --auto-correct. -Style/SpaceBeforeComment: - Enabled: false - -# Offense count: 76 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. -Style/SpaceInsideBlockBraces: - Enabled: false - -# Offense count: 133 -# Cop supports --auto-correct. -Style/SpaceInsideBrackets: - Enabled: false - -# Offense count: 778 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles. -Style/SpaceInsideHashLiteralBraces: - Enabled: false - -# Offense count: 9 -# Cop supports --auto-correct. -Style/SpaceInsideParens: - Enabled: false - -# Offense count: 3 -# Cop supports --auto-correct. -Style/SpaceInsideRangeLiteral: - Enabled: false +# Configuration parameters: Include. +# Include: app/helpers/**/*.rb +Rails/HelperInstanceVariable: + Exclude: + - 'app/helpers/application_helper.rb' + - 'app/helpers/title_helper.rb' + - 'app/helpers/trace_helper.rb' -# Offense count: 2 -# Cop supports --auto-correct. -Style/SpecialGlobalVars: - Enabled: false +# Offense count: 5 +# Configuration parameters: Include. +# Include: db/migrate/*.rb +Rails/NotNullColumn: + Exclude: + - 'db/migrate/002_cleanup_osm_db.rb' + - 'db/migrate/020_populate_node_tags_and_remove.rb' + - 'db/migrate/021_move_to_innodb.rb' + - 'db/migrate/025_add_end_time_to_changesets.rb' + - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 6639 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/StringLiterals: - Enabled: false +# Offense count: 18 +Rails/OutputSafety: + Exclude: + - 'app/controllers/users_controller.rb' + - 'app/helpers/application_helper.rb' + - 'app/helpers/changesets_helper.rb' + - 'app/helpers/geocoder_helper.rb' + - 'app/helpers/note_helper.rb' + - 'app/helpers/open_graph_helper.rb' + - 'app/helpers/user_blocks_helper.rb' + - 'lib/rich_text.rb' + - 'test/helpers/application_helper_test.rb' -# Offense count: 8 +# Offense count: 94 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/StringLiteralsInInterpolation: +# Configuration parameters: EnforcedStyle. +# SupportedStyles: strict, flexible +Rails/TimeZone: Enabled: false # Offense count: 1 -Style/StructInheritance: - Enabled: false - -# Offense count: 38 -# Cop supports --auto-correct. -# Configuration parameters: IgnoredMethods. -Style/SymbolProc: - Enabled: false - -# Offense count: 218 -# Cop supports --auto-correct. -Style/Tab: - Enabled: false - -# Offense count: 6 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/TrailingBlankLines: - Enabled: false - -# Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles. -Style/TrailingComma: - Enabled: false +# Configuration parameters: AllowedChars. +Style/AsciiComments: + Exclude: + - 'test/models/message_test.rb' -# Offense count: 1052 -# Cop supports --auto-correct. -Style/TrailingWhitespace: - Enabled: false +# Offense count: 27 +# Configuration parameters: EnforcedStyle. +# SupportedStyles: annotated, template, unannotated +Style/FormatStringToken: + Exclude: + - 'app/models/concerns/geo_record.rb' + - 'app/views/api/map/_bounds.xml.builder' + - 'lib/bounding_box.rb' + - 'test/controllers/api/map_controller_test.rb' + - 'test/controllers/api/relations_controller_test.rb' + - 'test/controllers/api/ways_controller_test.rb' + - 'test/lib/bounding_box_test.rb' -# Offense count: 13 +# Offense count: 539 # Cop supports --auto-correct. -# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, Whitelist. -Style/TrivialAccessors: - Enabled: false - -# Offense count: 10 -Style/UnlessElse: +# Configuration parameters: EnforcedStyle. +# SupportedStyles: always, never +Style/FrozenStringLiteralComment: Enabled: false # Offense count: 2 -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/VariableName: - Enabled: false - -# Offense count: 27 # Cop supports --auto-correct. -Style/WhenThen: - Enabled: false - -# Offense count: 3 -# Cop supports --auto-correct. -Style/WhileUntilDo: - Enabled: false - -# Offense count: 1 -# Configuration parameters: MaxLineLength. -Style/WhileUntilModifier: - Enabled: false +Style/IfUnlessModifier: + Exclude: + - 'app/controllers/api/ways_controller.rb' -# Offense count: 85 +# Offense count: 70 # Cop supports --auto-correct. -# Configuration parameters: WordRegex. -Style/WordArray: - MinSize: 14 +# Configuration parameters: Strict. +Style/NumericLiterals: + MinDigits: 11