X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/e222329d043592af299eed12cf6ad16969c1b46f..e4c40cbd36567d050f1b779f1444c4ef26c50a5b:/.rubocop_todo.yml diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index e922a4b79..90bfaa8f9 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2021-01-11 19:00:54 UTC using RuboCop version 1.8.1. +# on 2021-09-14 19:29:59 UTC using RuboCop version 1.21.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -14,14 +14,27 @@ require: - rubocop-rails - rubocop-rake -# Offense count: 544 +# Offense count: 524 # Cop supports --auto-correct. -# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https Layout/LineLength: - Max: 254 + Max: 270 -# Offense count: 36 +# Offense count: 62 +# Cop supports --auto-correct. +Lint/AmbiguousOperatorPrecedence: + Exclude: + - 'app/controllers/geocoder_controller.rb' + - 'app/models/user.rb' + - 'lib/bounding_box.rb' + - 'lib/osm.rb' + - 'lib/rich_text.rb' + - 'lib/short_link.rb' + - 'test/controllers/api/old_nodes_controller_test.rb' + - 'test/lib/short_link_test.rb' + +# Offense count: 34 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: @@ -50,12 +63,12 @@ Lint/DuplicateBranch: - 'app/helpers/browse_tags_helper.rb' - 'lib/password_hash.rb' -# Offense count: 487 +# Offense count: 643 # Configuration parameters: IgnoredMethods, CountRepeatedAttributes. Metrics/AbcSize: - Max: 235 + Max: 189 -# Offense count: 62 +# Offense count: 69 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. # IgnoredMethods: refine Metrics/BlockLength: @@ -66,17 +79,17 @@ Metrics/BlockLength: Metrics/BlockNesting: Max: 5 -# Offense count: 24 +# Offense count: 25 # Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 587 + Max: 337 -# Offense count: 52 +# Offense count: 58 # Configuration parameters: IgnoredMethods. Metrics/CyclomaticComplexity: - Max: 26 + Max: 25 -# Offense count: 553 +# Offense count: 716 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. Metrics/MethodLength: Max: 179 @@ -86,16 +99,16 @@ Metrics/MethodLength: Metrics/ParameterLists: Max: 6 -# Offense count: 56 +# Offense count: 62 # Configuration parameters: IgnoredMethods. Metrics/PerceivedComplexity: Max: 26 -# Offense count: 365 +# Offense count: 528 Minitest/MultipleAssertions: - Max: 97 + Max: 54 -# Offense count: 4 +# Offense count: 3 Naming/AccessorMethodName: Exclude: - 'app/controllers/application_controller.rb' @@ -142,6 +155,9 @@ Rails/HelperInstanceVariable: Exclude: - 'app/helpers/title_helper.rb' +# Offense count: 1 +# Configuration parameters: Include. +# Include: app/controllers/**/*.rb Rails/LexicallyScopedActionFilter: Exclude: - 'app/controllers/oauth2_applications_controller.rb' @@ -157,7 +173,7 @@ Rails/NotNullColumn: - 'db/migrate/025_add_end_time_to_changesets.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 8 +# Offense count: 9 Rails/OutputSafety: Exclude: - 'app/controllers/sessions_controller.rb' @@ -166,30 +182,30 @@ Rails/OutputSafety: - 'lib/rich_text.rb' - 'test/helpers/application_helper_test.rb' -# Offense count: 80 +# Offense count: 91 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible Rails/TimeZone: Enabled: false -# Offense count: 8 +# Offense count: 6 +# Cop supports --auto-correct. Rake/Desc: Exclude: - 'lib/tasks/auto_annotate_models.rake' - 'lib/tasks/eslint.rake' - 'lib/tasks/subscribe_diary_authors.rake' - 'lib/tasks/subscribe_old_changesets.rake' - - 'lib/tasks/testing.rake' -# Offense count: 558 +# Offense count: 602 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never Style/FrozenStringLiteralComment: Enabled: false -# Offense count: 54 +# Offense count: 73 # Cop supports --auto-correct. # Configuration parameters: Strict. Style/NumericLiterals: