X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/e23744bd8dbdd9c0beef84e8920fc258f332197c..9448eab143cd052e9ee48cabdf13a8525add1b2c:/app/controllers/application_controller.rb diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index 66ab92a5c..0c4117047 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -192,6 +192,8 @@ class ApplicationController < ActionController::Base report_error message, :bad_request rescue OSM::APIError => ex report_error ex.message, ex.status + rescue ActionController::UnknownAction => ex + raise rescue Exception => ex logger.info("API threw unexpected #{ex.class} exception: #{ex.message}") ex.backtrace.each { |l| logger.info(l) } @@ -208,12 +210,54 @@ class ApplicationController < ActionController::Base end def api_call_timeout - Timeout::timeout(APP_CONFIG['api_timeout'], OSM::APITimeoutError) do + SystemTimer.timeout_after(APP_CONFIG['api_timeout']) do yield end + rescue Timeout::Error + raise OSM::APITimeoutError + end + + ## + # extend caches_action to include the parameters, locale and logged in + # status in all cache keys + def self.caches_action(*actions) + options = actions.extract_options! + cache_path = options[:cache_path] || Hash.new + + options[:cache_path] = Proc.new do |controller| + user = controller.instance_variable_get("@user") + + case + when user.nil? then user = :none + when user.display_name == controller.params[:display_name] then user = :self + when user.administrator? then user = :administrator + when user.moderator? then user = :moderator + else user = :other + end + + cache_path.merge(controller.params).merge(:locale => I18n.locale, :user => user) + end + + actions.push(options) + + super *actions + end + + ## + # extend expire_action to expire all variants + def expire_action(options = {}) + path = ActionCachePath.path_for(self, options, false).gsub('?', '.').gsub(':', '.') + expire_fragment(Regexp.new(Regexp.escape(path) + "\\..*")) + end + + ## + # is the requestor logged in? + def logged_in? + !@user.nil? end private + # extract authorisation credentials from headers, returns user = nil if none def get_auth_data if request.env.has_key? 'X-HTTP_AUTHORIZATION' # where mod_rewrite might have put it