X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/e731dd71a77ad4ad1e9db22535e89444bb98e5d9..ea5b8c90db0b8354321aba6f6b373323a33f4f34:/.rubocop.yml?ds=sidebyside diff --git a/.rubocop.yml b/.rubocop.yml index cbd62a052..c0f0c1fa0 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,11 +1,16 @@ inherit_from: .rubocop_todo.yml require: + - rubocop-capybara + - rubocop-factory_bot + - rubocop-minitest - rubocop-performance - rubocop-rails + - rubocop-rake AllCops: - TargetRubyVersion: 2.5 + TargetRubyVersion: 3.0 + NewCops: enable Exclude: - 'vendor/**/*' @@ -29,21 +34,27 @@ Metrics/ClassLength: Exclude: - 'test/**/*' +Metrics/ModuleLength: + Max: 150 + Naming/FileName: Exclude: - 'script/deliver-message' - - 'script/locale/reload-languages' - 'script/update-spam-blocks' -Naming/UncommunicativeMethodParamName: +Naming/MethodParameterName: Enabled: false -Rails/ApplicationRecord: +# This conflicts with Strong Migrations, which can't check `change_table` +Rails/BulkChangeTable: Enabled: false Rails/CreateTableWithTimestamps: Enabled: false +Rails/FindBy: + IgnoreWhereFirst: false + Rails/FindEach: Enabled: false @@ -53,7 +64,7 @@ Rails/HasManyOrHasOneDependent: Rails/HttpPositionalArguments: Enabled: false -Rails/InverseOf: +Rails/ReflectionClassName: Enabled: false Rails/SkipsModelValidations: @@ -61,11 +72,12 @@ Rails/SkipsModelValidations: - 'db/migrate/*.rb' - 'app/controllers/users_controller.rb' -Style/BracesAroundHashParameters: - EnforcedStyle: context_dependent +Style/Documentation: + Enabled: false Style/FormatStringToken: - EnforcedStyle: template + Exclude: + - 'config/routes.rb' Style/IfInsideElse: Enabled: false @@ -73,12 +85,21 @@ Style/IfInsideElse: Style/GuardClause: Enabled: false +Style/HashEachMethods: + Enabled: true + Style/HashSyntax: EnforcedStyle: hash_rockets Exclude: - 'lib/tasks/testing.rake' - 'config/initializers/wrap_parameters.rb' +Style/HashTransformKeys: + Enabled: true + +Style/HashTransformValues: + Enabled: true + Style/MixinUsage: Exclude: - 'bin/setup'