X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/ef7f3d800cbdd49b692df10d312e5fd880e2e938..6c2093b29d74b145b85e61c4fff09b5f13afa0e5:/db/migrate/008_remove_segments.rb?ds=sidebyside diff --git a/db/migrate/008_remove_segments.rb b/db/migrate/008_remove_segments.rb index 2820f82f8..5c9bd1c39 100644 --- a/db/migrate/008_remove_segments.rb +++ b/db/migrate/008_remove_segments.rb @@ -1,8 +1,8 @@ -require 'migrate' +require "migrate" -class RemoveSegments < ActiveRecord::Migration +class RemoveSegments < ActiveRecord::Migration[5.0] def self.up - have_segs = select_value("SELECT count(*) FROM current_segments").to_i != 0 + have_segs = select_value("SELECT count(*) FROM current_segments").to_i.nonzero? if have_segs prefix = File.join Dir.tmpdir, "008_remove_segments.#{$PROCESS_ID}." @@ -10,16 +10,16 @@ class RemoveSegments < ActiveRecord::Migration cmd = "db/migrate/008_remove_segments_helper" src = "#{cmd}.cc" if !File.exist?(cmd) || File.mtime(cmd) < File.mtime(src) - system('c++ -O3 -Wall `mysql_config --cflags --libs` ' + - "#{src} -o #{cmd}") || fail + system("c++ -O3 -Wall `mysql_config --cflags --libs` " \ + "#{src} -o #{cmd}") || raise end conn_opts = ActiveRecord::Base.connection - .instance_eval { @connection_options } + .instance_eval { @connection_options } args = conn_opts.map(&:to_s) + [prefix] - fail "#{cmd} failed" unless system cmd, *args + raise "#{cmd} failed" unless system cmd, *args - tempfiles = %w(ways way_nodes way_tags relations relation_members relation_tags) + tempfiles = %w[ways way_nodes way_tags relations relation_members relation_tags] .map { |base| prefix + base } ways, way_nodes, way_tags, relations, relation_members, relation_tags = tempfiles @@ -53,7 +53,7 @@ class RemoveSegments < ActiveRecord::Migration # now get the data back csvopts = "FIELDS TERMINATED BY ',' ENCLOSED BY '\"' ESCAPED BY '\"' LINES TERMINATED BY '\\n'" - tempfiles.each { |fn| File.chmod 0644, fn } if have_segs + tempfiles.each { |fn| File.chmod 0o644, fn } if have_segs if have_segs execute "LOAD DATA INFILE '#{ways}' INTO TABLE ways #{csvopts} (id, user_id, timestamp) SET visible = 1, version = 1" @@ -81,6 +81,6 @@ class RemoveSegments < ActiveRecord::Migration end def self.down - fail ActiveRecord::IrreversibleMigration + raise ActiveRecord::IrreversibleMigration end end