X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/efcb56b68b4ec7b6d4e2986b141e69166c481aee..10999cfc5e6f64f1b6d81ddb4a2f751c694bcbc5:/app/models/node.rb diff --git a/app/models/node.rb b/app/models/node.rb index 2e71813ff..a5346e87f 100644 --- a/app/models/node.rb +++ b/app/models/node.rb @@ -21,7 +21,7 @@ # current_nodes_changeset_id_fkey (changeset_id => changesets.id) # -class Node < ActiveRecord::Base +class Node < ApplicationRecord require "xml/libxml" include GeoRecord @@ -71,19 +71,21 @@ class Node < ActiveRecord::Base end # Read in xml as text and return it's Node object representation - def self.from_xml(xml, create = false) + def self.from_xml(xml, create: false) p = XML::Parser.string(xml, :options => XML::Parser::Options::NOERROR) doc = p.parse + pt = doc.find_first("//osm/node") - doc.find("//osm/node").each do |pt| - return Node.from_xml_node(pt, create) + if pt + Node.from_xml_node(pt, :create => create) + else + raise OSM::APIBadXMLError.new("node", xml, "XML doesn't contain an osm/node element.") end - raise OSM::APIBadXMLError.new("node", xml, "XML doesn't contain an osm/node element.") rescue LibXML::XML::Error, ArgumentError => e raise OSM::APIBadXMLError.new("node", xml, e.message) end - def self.from_xml_node(pt, create = false) + def self.from_xml_node(pt, create: false) node = Node.new raise OSM::APIBadXMLError.new("node", pt, "lat missing") if pt["lat"].nil?