X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/effb1b7f4170bb7244c4dfffcbe6134fe00e2bc4..5bb23f6f5f8fed81f1166a15344e44afa7fbb480:/test/controllers/issues_controller_test.rb?ds=inline diff --git a/test/controllers/issues_controller_test.rb b/test/controllers/issues_controller_test.rb index 161fd6d4c..167bcc7b6 100644 --- a/test/controllers/issues_controller_test.rb +++ b/test/controllers/issues_controller_test.rb @@ -1,244 +1,232 @@ require "test_helper" -class IssuesControllerTest < ActionController::TestCase - teardown do - # cleanup any emails set off by the test - ActionMailer::Base.deliveries.clear - end - - def test_view_dashboard_without_auth - # Access issues_path without login - get :index - assert_response :redirect +class IssuesControllerTest < ActionDispatch::IntegrationTest + def test_index + # Access issues list without login + get issues_path assert_redirected_to login_path(:referer => issues_path) - # Access issues_path as normal user - session[:user] = create(:user).id - get :index - assert_response :redirect - assert_redirected_to root_path - - # Access issues_path by admin - session[:user] = create(:administrator_user).id - get :index - # this is redirected because there are no issues?! - assert_response :redirect - assert_redirected_to issues_path + # Access issues list as normal user + session_for(create(:user)) + get issues_path + assert_redirected_to :controller => :errors, :action => :forbidden - # Access issues_path by moderator - session[:user] = create(:moderator_user).id - get :index - # this is redirected because there are no issues?! - assert_response :redirect - assert_redirected_to issues_path - end + # Access issues list as administrator + session_for(create(:administrator_user)) + get issues_path + assert_response :success - def test_new_issue_without_login - # Test creation of a new issue and a new report without logging in - get :new, :params => { :reportable_id => 1, :reportable_type => "User", :reported_user_id => 1 } - assert_response :redirect - assert_redirected_to login_path(:referer => new_issue_path(:reportable_id => 1, :reportable_type => "User", :reported_user_id => 1)) + # Access issues list as moderator + session_for(create(:moderator_user)) + get issues_path + assert_response :success end - def test_new_issue_after_login - # Test creation of a new issue and a new report + def test_show_moderator target_user = create(:user) + issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator") + + # Access issue without login + get issue_path(issue) + assert_redirected_to login_path(:referer => issue_path(issue)) - # Login - session[:user] = create(:user).id + # Access issue as normal user + session_for(create(:user)) + get issue_path(issue) + assert_redirected_to :controller => :errors, :action => :forbidden - assert_equal Issue.count, 0 + # Access issue as administrator + session_for(create(:administrator_user)) + get issue_path(issue) + assert_redirected_to :controller => :errors, :action => :not_found - # Create an Issue and a report - get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id } + # Access issue as moderator + session_for(create(:moderator_user)) + get issue_path(issue) assert_response :success - assert_difference "Issue.count", 1 do - details = "Details of a report" - post :create, - :params => { - :report => { :details => details }, - :report_type => "[OFFENSIVE]", - :issue => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id } - } - end - assert_equal Issue.count, 1 - assert_response :redirect - assert_redirected_to root_path end - def test_new_report_with_incomplete_details - # Test creation of a new issue and a new report + def test_show_administrator target_user = create(:user) + issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator") - # Login - session[:user] = create(:user).id + # Access issue without login + get issue_path(issue) + assert_redirected_to login_path(:referer => issue_path(issue)) - assert_equal Issue.count, 0 + # Access issue as normal user + session_for(create(:user)) + get issue_path(issue) + assert_redirected_to :controller => :errors, :action => :forbidden - # Create an Issue and a report - get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id } - assert_response :success - assert_difference "Issue.count", 1 do - details = "Details of a report" - post :create, - :params => { - :report => { :details => details }, - :report_type => "[OFFENSIVE]", - :issue => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id } - } - end - assert_equal Issue.count, 1 - assert_response :redirect - assert_redirected_to root_path + # Access issue as moderator + session_for(create(:moderator_user)) + get issue_path(issue) + assert_redirected_to :controller => :errors, :action => :not_found - get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id } + # Access issue as administrator + session_for(create(:administrator_user)) + get issue_path(issue) assert_response :success - - # Report without report_type - assert_no_difference "Issue.count" do - details = "Details of another report under the same issue" - post :create, - :params => { - :report => { :details => details }, - :issue => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id } - } - end - assert_response :redirect - assert_equal Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").reports.count, 1 - - # Report without details - assert_no_difference "Issue.count" do - post :create, - :params => { - :report_type => "[OFFENSIVE]", - :issue => { :reportable_id => 1, :reportable_type => "User", :reported_user_id => 2 } - } - end - assert_response :redirect - assert_equal Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").reports.count, 1 end - def test_new_report_with_complete_details - # Test creation of a new issue and a new report + def test_resolve_moderator target_user = create(:user) + issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator") - # Login - session[:user] = create(:user).id + # Resolve issue without login + post resolve_issue_path(issue) + assert_response :forbidden - assert_equal Issue.count, 0 + # Resolve issue as normal user + session_for(create(:user)) + post resolve_issue_path(issue) + assert_redirected_to :controller => :errors, :action => :forbidden - # Create an Issue and a report - get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id } - assert_response :success - assert_difference "Issue.count", 1 do - details = "Details of a report" - post :create, - :params => { - :report => { :details => details }, - :report_type => "[OFFENSIVE]", - :issue => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id } - } - end - assert_equal Issue.count, 1 - assert_response :redirect - assert_redirected_to root_path + # Resolve issue as administrator + session_for(create(:administrator_user)) + post resolve_issue_path(issue) + assert_redirected_to :controller => :errors, :action => :not_found + assert_not_predicate issue.reload, :resolved? - # Create a report for an existing Issue - get :new, :params => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id } - assert_response :success - assert_no_difference "Issue.count" do - details = "Details of another report under the same issue" - post :create, - :params => { - :report => { :details => details }, - :report_type => "[OFFENSIVE]", - :issue => { :reportable_id => target_user.id, :reportable_type => "User", :reported_user_id => target_user.id } - } - end + # Resolve issue as moderator + session_for(create(:moderator_user)) + post resolve_issue_path(issue) assert_response :redirect - report_count = Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").reports.count - assert_equal report_count, 2 + assert_predicate issue.reload, :resolved? end - def test_change_status_by_normal_user + def test_resolve_administrator target_user = create(:user) - issue = create(:issue, :reportable => target_user, :reported_user => target_user) + issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator") - # Login as normal user - session[:user] = create(:user).id + # Resolve issue without login + post resolve_issue_path(issue) + assert_response :forbidden - assert_equal Issue.count, 1 + # Resolve issue as normal user + session_for(create(:user)) + post resolve_issue_path(issue) + assert_redirected_to :controller => :errors, :action => :forbidden - get :resolve, :params => { :id => issue.id } + # Resolve issue as moderator + session_for(create(:moderator_user)) + post resolve_issue_path(issue) + assert_redirected_to :controller => :errors, :action => :not_found + assert_not_predicate issue.reload, :resolved? + # Resolve issue as administrator + session_for(create(:administrator_user)) + post resolve_issue_path(issue) assert_response :redirect - assert_redirected_to root_path + assert_predicate issue.reload, :resolved? end - def test_change_status_by_admin + def test_ignore_moderator target_user = create(:user) - issue = create(:issue, :reportable => target_user, :reported_user => target_user) + issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator") - # Login as administrator - session[:user] = create(:administrator_user).id + # Ignore issue without login + post ignore_issue_path(issue) + assert_response :forbidden - # Test 'Resolved' - get :resolve, :params => { :id => issue.id } - assert_equal Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").resolved?, true - assert_response :redirect + # Ignore issue as normal user + session_for(create(:user)) + post ignore_issue_path(issue) + assert_redirected_to :controller => :errors, :action => :forbidden - # Test 'Reopen' - get :reopen, :params => { :id => issue.id } - assert_equal Issue.find_by(:reportable_id => target_user.id, :reportable_type => "User").open?, true - assert_response :redirect + # Ignore issue as administrator + session_for(create(:administrator_user)) + post ignore_issue_path(issue) + assert_redirected_to :controller => :errors, :action => :not_found + assert_not_predicate issue.reload, :ignored? - # Test 'Ignored' - get :ignore, :params => { :id => issue.id } - assert_equal Issue.find_by(:reportable_id => target_user, :reportable_type => "User").ignored?, true + # Ignore issue as moderator + session_for(create(:moderator_user)) + post ignore_issue_path(issue) assert_response :redirect + assert_predicate issue.reload, :ignored? end - def test_search_issues - good_user = create(:user) - bad_user = create(:user) - create(:issue, :reportable => bad_user, :reported_user => bad_user, :issue_type => "administrator") - # Login as administrator - session[:user] = create(:administrator_user).id + def test_ignore_administrator + target_user = create(:user) + issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator") - # No issues against the user - get :index, :params => { :search_by_user => good_user.display_name } - assert_response :redirect - assert_redirected_to issues_path + # Ignore issue without login + post ignore_issue_path(issue) + assert_response :forbidden - # User doesn't exist - get :index, :params => { :search_by_user => "test1000" } - assert_response :redirect - assert_redirected_to issues_path + # Ignore issue as normal user + session_for(create(:user)) + post ignore_issue_path(issue) + assert_redirected_to :controller => :errors, :action => :forbidden - # Find Issue against bad_user - get :index, :params => { :search_by_user => bad_user.display_name } - assert_response :success + # Ignore issue as moderator + session_for(create(:moderator_user)) + post ignore_issue_path(issue) + assert_redirected_to :controller => :errors, :action => :not_found + assert_not_predicate issue.reload, :ignored? + + # Ignore issue as administrator + session_for(create(:administrator_user)) + post ignore_issue_path(issue) + assert_response :redirect + assert_predicate issue.reload, :ignored? end - def test_comment_by_normal_user - issue = create(:issue) + def test_reopen_moderator + target_user = create(:user) + issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "moderator") + + issue.resolve! + + # Reopen issue without login + post reopen_issue_path(issue) + assert_response :forbidden + + # Reopen issue as normal user + session_for(create(:user)) + post reopen_issue_path(issue) + assert_redirected_to :controller => :errors, :action => :forbidden - # Login as normal user - session[:user] = create(:user).id + # Reopen issue as administrator + session_for(create(:administrator_user)) + post reopen_issue_path(issue) + assert_redirected_to :controller => :errors, :action => :not_found + assert_not_predicate issue.reload, :open? - get :comment, :params => { :id => issue.id } + # Reopen issue as moderator + session_for(create(:moderator_user)) + post reopen_issue_path(issue) assert_response :redirect - assert_redirected_to root_path + assert_predicate issue.reload, :open? end - def test_comment - issue = create(:issue) + def test_reopen_administrator + target_user = create(:user) + issue = create(:issue, :reportable => target_user, :reported_user => target_user, :assigned_role => "administrator") + + issue.resolve! + + # Reopen issue without login + post reopen_issue_path(issue) + assert_response :forbidden + + # Reopen issue as normal user + session_for(create(:user)) + post reopen_issue_path(issue) + assert_redirected_to :controller => :errors, :action => :forbidden - # Login as administrator - session[:user] = create(:administrator_user).id + # Reopen issue as moderator + session_for(create(:moderator_user)) + post reopen_issue_path(issue) + assert_redirected_to :controller => :errors, :action => :not_found + assert_not_predicate issue.reload, :open? - get :comment, :params => { :id => issue.id, :issue_comment => { :body => "test comment" } } + # Reopen issue as administrator + session_for(create(:administrator_user)) + post reopen_issue_path(issue) assert_response :redirect - assert_redirected_to issue + assert_predicate issue.reload, :open? end end