X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/f1c6a87aa137c11d0aff5a4b0e563ac2c2a8f82d..e6b0afc6c84928ac7cf2c746080812a07f23aca9:/test/abilities/api_capability_test.rb?ds=sidebyside diff --git a/test/abilities/api_capability_test.rb b/test/abilities/api_capability_test.rb index 8a98f29e0..8f5272c50 100644 --- a/test/abilities/api_capability_test.rb +++ b/test/abilities/api_capability_test.rb @@ -2,132 +2,120 @@ require "test_helper" -class ApiCapabilityTest < ActiveSupport::TestCase - def tokens(*toks) - AccessToken.new do |token| - toks.each do |t| - token.public_send("#{t}=", true) - end - end - end -end - -class ChangesetCommentApiCapabilityTest < ApiCapabilityTest +class ChangesetCommentApiCapabilityTest < ActiveSupport::TestCase test "as a normal user with permissionless token" do - token = create(:access_token) - capability = ApiCapability.new token + token = create(:oauth_access_token) + ability = ApiAbility.new token [:create, :destroy, :restore].each do |action| - assert capability.cannot? action, ChangesetComment + assert ability.cannot? action, ChangesetComment end end - test "as a normal user with allow_write_api token" do - token = create(:access_token, :allow_write_api => true) - capability = ApiCapability.new token + test "as a normal user with write_api token" do + token = create(:oauth_access_token, :scopes => %w[write_api]) + ability = ApiAbility.new token [:destroy, :restore].each do |action| - assert capability.cannot? action, ChangesetComment + assert ability.cannot? action, ChangesetComment end [:create].each do |action| - assert capability.can? action, ChangesetComment + assert ability.can? action, ChangesetComment end end test "as a moderator with permissionless token" do - token = create(:access_token, :user => create(:moderator_user)) - capability = ApiCapability.new token + token = create(:oauth_access_token, :resource_owner_id => create(:moderator_user).id) + ability = ApiAbility.new token [:create, :destroy, :restore].each do |action| - assert capability.cannot? action, ChangesetComment + assert ability.cannot? action, ChangesetComment end end - test "as a moderator with allow_write_api token" do - token = create(:access_token, :user => create(:moderator_user), :allow_write_api => true) - capability = ApiCapability.new token + test "as a moderator with write_api token" do + token = create(:oauth_access_token, :resource_owner_id => create(:moderator_user).id, :scopes => %w[write_api]) + ability = ApiAbility.new token [:create, :destroy, :restore].each do |action| - assert capability.can? action, ChangesetComment + assert ability.can? action, ChangesetComment end end end -class NoteApiCapabilityTest < ApiCapabilityTest +class NoteApiCapabilityTest < ActiveSupport::TestCase test "as a normal user with permissionless token" do - token = create(:access_token) - capability = ApiCapability.new token + token = create(:oauth_access_token) + ability = ApiAbility.new token [:create, :comment, :close, :reopen, :destroy].each do |action| - assert capability.cannot? action, Note + assert ability.cannot? action, Note end end - test "as a normal user with allow_write_notes token" do - token = create(:access_token, :allow_write_notes => true) - capability = ApiCapability.new token + test "as a normal user with write_notes token" do + token = create(:oauth_access_token, :scopes => %w[write_notes]) + ability = ApiAbility.new token [:destroy].each do |action| - assert capability.cannot? action, Note + assert ability.cannot? action, Note end [:create, :comment, :close, :reopen].each do |action| - assert capability.can? action, Note + assert ability.can? action, Note end end test "as a moderator with permissionless token" do - token = create(:access_token, :user => create(:moderator_user)) - capability = ApiCapability.new token + token = create(:oauth_access_token, :resource_owner_id => create(:moderator_user).id) + ability = ApiAbility.new token [:destroy].each do |action| - assert capability.cannot? action, Note + assert ability.cannot? action, Note end end - test "as a moderator with allow_write_notes token" do - token = create(:access_token, :user => create(:moderator_user), :allow_write_notes => true) - capability = ApiCapability.new token + test "as a moderator with write_notes token" do + token = create(:oauth_access_token, :resource_owner_id => create(:moderator_user).id, :scopes => %w[write_notes]) + ability = ApiAbility.new token [:destroy].each do |action| - assert capability.can? action, Note + assert ability.can? action, Note end end end -class UserApiCapabilityTest < ApiCapabilityTest +class UserApiCapabilityTest < ActiveSupport::TestCase test "user preferences" do - # a user with no tokens - capability = ApiCapability.new nil - [:index, :show, :update_all, :update, :destroy].each do |act| - assert capability.cannot? act, UserPreference - end - # A user with empty tokens - capability = ApiCapability.new tokens + token = create(:oauth_access_token) + ability = ApiAbility.new token [:index, :show, :update_all, :update, :destroy].each do |act| - assert capability.cannot? act, UserPreference + assert ability.cannot? act, UserPreference end - capability = ApiCapability.new tokens(:allow_read_prefs) + token = create(:oauth_access_token, :scopes => %w[read_prefs]) + ability = ApiAbility.new token [:update_all, :update, :destroy].each do |act| - assert capability.cannot? act, UserPreference + assert ability.cannot? act, UserPreference end [:index, :show].each do |act| - assert capability.can? act, UserPreference + assert ability.can? act, UserPreference end - capability = ApiCapability.new tokens(:allow_write_prefs) + token = create(:oauth_access_token, :scopes => %w[write_prefs]) + ability = ApiAbility.new token + [:index, :show].each do |act| - assert capability.cannot? act, UserPreference + assert ability.cannot? act, UserPreference end [:update_all, :update, :destroy].each do |act| - assert capability.can? act, UserPreference + assert ability.can? act, UserPreference end end end