X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/f6695c9079f4eeeecaa796c879868f797f97cd55..399ade116adb8250bbf92efa8dfeb3ca1090c7e4:/test/models/changeset_comment_test.rb?ds=inline diff --git a/test/models/changeset_comment_test.rb b/test/models/changeset_comment_test.rb index 8215ce129..b620dc8e7 100644 --- a/test/models/changeset_comment_test.rb +++ b/test/models/changeset_comment_test.rb @@ -1,45 +1,43 @@ -# -*- coding: utf-8 -*- require "test_helper" class ChangesetCommentTest < ActiveSupport::TestCase - fixtures :changesets - # validations def test_does_not_accept_invalid_author comment = create(:changeset_comment) comment.author = nil - assert !comment.valid? + assert_not comment.valid? comment.author_id = 999111 - assert !comment.valid? + assert_not comment.valid? end def test_does_not_accept_invalid_changeset comment = create(:changeset_comment) comment.changeset = nil - assert !comment.valid? + assert_not comment.valid? comment.changeset_id = 999111 - assert !comment.valid? + assert_not comment.valid? end def test_does_not_accept_empty_visible comment = create(:changeset_comment) comment.visible = nil - assert !comment.valid? + assert_not comment.valid? end def test_comments_of_changeset_count - create_list(:changeset_comment, 3, :changeset_id => changesets(:normal_user_closed_change).id) - assert_equal 3, Changeset.find(changesets(:normal_user_closed_change).id).comments.count + changeset = create(:changeset) + create_list(:changeset_comment, 3, :changeset_id => changeset.id) + assert_equal 3, Changeset.find(changeset.id).comments.count end def test_body_valid - ok = %W(Name vergrößern foo\nbar - ルシステムにも対応します 輕觸搖晃的遊戲) + ok = %W[Name vergrößern foo\nbar + ルシステムにも対応します 輕觸搖晃的遊戲] bad = ["foo\x00bar", "foo\x08bar", "foo\x1fbar", "foo\x7fbar", "foo\ufffebar", "foo\uffffbar"] @@ -52,7 +50,7 @@ class ChangesetCommentTest < ActiveSupport::TestCase bad.each do |body| changeset_comment = create(:changeset_comment) changeset_comment.body = body - assert !changeset_comment.valid?, "#{body} is valid when it shouldn't be" + assert_not changeset_comment.valid?, "#{body} is valid when it shouldn't be" end end end