X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/fa51bcbcb2868486a584a4cb4928a02899623d79..fda87833bac224504252f9bda6b3304b691ad5ab:/app/controllers/application_controller.rb diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index 25c430f1c..176fd8c2e 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -114,7 +114,7 @@ class ApplicationController < ActionController::Base def check_database_writable(need_api: false) if Settings.status == "database_offline" || Settings.status == "database_readonly" || - (need_api && (Settings.status == "api_offline" || Settings.status == "api_readonly")) + (need_api && %w[api_offline api_readonly].include?(Settings.status)) if request.xhr? report_error "Database offline for maintenance", :service_unavailable else @@ -304,10 +304,7 @@ class ApplicationController < ActionController::Base end def deny_access(_exception) - if doorkeeper_token - set_locale - report_error t("oauth.permissions.missing"), :forbidden - elsif current_user + if current_user set_locale respond_to do |format| format.html { redirect_to :controller => "/errors", :action => "forbidden" } @@ -339,7 +336,7 @@ class ApplicationController < ActionController::Base begin referer = URI.parse(referer) - if referer.scheme == "http" || referer.scheme == "https" + if %w[http https].include?(referer.scheme) referer.scheme = nil referer.host = nil referer.port = nil @@ -354,10 +351,4 @@ class ApplicationController < ActionController::Base referer&.to_s end - - def scope_enabled?(scope) - doorkeeper_token&.includes_scope?(scope) - end - - helper_method :scope_enabled? end