X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/faf4c5aa7a3c75b89d32b7d2205d004f9aa99cb7..c203edda20370bb1760a091356f334d342ccb25b:/test/controllers/issues_controller_test.rb?ds=sidebyside

diff --git a/test/controllers/issues_controller_test.rb b/test/controllers/issues_controller_test.rb
index 980603e20..af0a86028 100644
--- a/test/controllers/issues_controller_test.rb
+++ b/test/controllers/issues_controller_test.rb
@@ -1,109 +1,144 @@
-require 'test_helper'
+require "test_helper"
 
 class IssuesControllerTest < ActionController::TestCase
-  fixtures :users,:user_roles
-
-  def test_new_issue_without_login
-    # Test creation of a new issue and a new report without logging in
-    get :new, {reportable_id: 1, reportable_type: "DiaryEntry", reported_user_id: 1}
+  def test_index
+    # Access issues list without login
+    get :index
     assert_response :redirect
-    assert_redirected_to login_path(:referer => new_issue_path(:reportable_id=>1, :reportable_type=>"DiaryEntry",:reported_user_id=> 1))
-  end
+    assert_redirected_to login_path(:referer => issues_path)
 
-  def test_new_issue_after_login
-    # Test creation of a new issue and a new report
+    # Access issues list as normal user
+    session[:user] = create(:user).id
+    get :index
+    assert_response :redirect
+    assert_redirected_to :controller => :errors, :action => :forbidden
 
-    # Login
-    session[:user] = users(:normal_user).id
+    # Access issues list as administrator
+    session[:user] = create(:administrator_user).id
+    get :index
+    assert_response :success
 
-    get :new, {reportable_id: 1, reportable_type: "DiaryEntry", reported_user_id: 1}
+    # Access issues list as moderator
+    session[:user] = create(:moderator_user).id
+    get :index
     assert_response :success
-    assert_difference "Issue.count",1 do 
-      details = "Details of a report"
-      post :create, { :report => { :deatils => details},
-                      :issue => { reportable_id: 1, reportable_type: "DiaryEntry", reported_user_id: 1} }
-    end
-    assert_response :redirect
   end
 
-  def test_new_report
-    # Test creation of a new report for an existing issue
+  def test_show
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user)
+
+    # Access issue without login
+    get :show, :params => { :id => issue.id }
+    assert_response :redirect
+    assert_redirected_to login_path(:referer => issue_path(issue))
 
-    # Login
-    session[:user] = users(:normal_user).id
+    # Access issue as normal user
+    session[:user] = create(:user).id
+    get :show, :params => { :id => issue.id }
+    assert_response :redirect
+    assert_redirected_to :controller => :errors, :action => :forbidden
 
-    get :new, {reportable_id: 1, reportable_type: "DiaryEntry", reported_user_id: 1}
+    # Access issue as administrator
+    session[:user] = create(:administrator_user).id
+    get :show, :params => { :id => issue.id }
     assert_response :success
-    assert_difference "Issue.count",1 do 
-      details = "Details of a report"
-      post :create, { :report => { :details => details},
-                      :issue => { reportable_id: 1, reportable_type: "DiaryEntry", reported_user_id: 1} }
-    end
-    assert_response :redirect
-    
-    get :new, {reportable_id: 1, reportable_type: "DiaryEntry", reported_user_id: 1}
+
+    # Access issue as moderator
+    session[:user] = create(:moderator_user).id
+    get :show, :params => { :id => issue.id }
     assert_response :success
-    assert_no_difference "Issue.count" do
-      details = "Details of another report under the same issue"
-      post :create, { :report => { :details => details},
-                      :issue => { reportable_id: 1, reportable_type: "DiaryEntry", reported_user_id: 1} }
-    end
+  end
+
+  def test_resolve
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user)
+
+    # Resolve issue without login
+    get :resolve, :params => { :id => issue.id }
     assert_response :redirect
-    assert_equal Issue.find_by_reportable_id_and_reportable_type(1,"DiaryEntry").reports.count,2
+    assert_redirected_to login_path(:referer => resolve_issue_path(issue))
+
+    # Resolve issue as normal user
+    session[:user] = create(:user).id
+    get :resolve, :params => { :id => issue.id }
+    assert_response :redirect
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Resolve issue as administrator
+    session[:user] = create(:administrator_user).id
+    get :resolve, :params => { :id => issue.id }
+    assert_response :redirect
+    assert_equal true, issue.reload.resolved?
+
+    issue.reopen!
+
+    # Resolve issue as moderator
+    session[:user] = create(:moderator_user).id
+    get :resolve, :params => { :id => issue.id }
+    assert_response :redirect
+    assert_equal true, issue.reload.resolved?
   end
 
-  def test_change_status_by_normal_user
-    # Login as normal user
-    session[:user] = users(:normal_user).id
-    
-    # Create Issue
+  def test_ignore
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user)
 
-    get :new, {reportable_id: 1, reportable_type: "DiaryEntry", user: 1}
-    assert_response :success
-    assert_difference "Issue.count",1 do 
-      details = "Details of a report"
-      post :create, { :report => { :deatils => details},
-                      :issue => { reportable_id: 1, reportable_type: "DiaryEntry", reported_user_id: 1} }
-    end
+    # Ignore issue without login
+    get :ignore, :params => { :id => issue.id }
+    assert_response :redirect
+    assert_redirected_to login_path(:referer => ignore_issue_path(issue))
+
+    # Ignore issue as normal user
+    session[:user] = create(:user).id
+    get :ignore, :params => { :id => issue.id }
     assert_response :redirect
-    
-    get :resolve, id: Issue.find_by_reportable_id_and_reportable_type(1,"DiaryEntry").id
+    assert_redirected_to :controller => :errors, :action => :forbidden
+
+    # Ignore issue as administrator
+    session[:user] = create(:administrator_user).id
+    get :ignore, :params => { :id => issue.id }
+    assert_response :redirect
+    assert_equal true, issue.reload.ignored?
+
+    issue.reopen!
+
+    # Ignore issue as moderator
+    session[:user] = create(:moderator_user).id
+    get :ignore, :params => { :id => issue.id }
     assert_response :redirect
-    assert_redirected_to root_path
+    assert_equal true, issue.reload.ignored?
   end
 
-  def test_change_status_by_admin
-    # Login as normal user
-    session[:user] = users(:normal_user).id
+  def test_reopen
+    target_user = create(:user)
+    issue = create(:issue, :reportable => target_user, :reported_user => target_user)
 
-    # Create Issue
+    issue.resolve!
 
-    get :new, {reportable_id: 1, reportable_type: "DiaryEntry", user: 1}
-    assert_response :success
-    assert_difference "Issue.count",1 do 
-      details = "Details of a report"
-      post :create, { :report => { :deatils => details},
-                      :issue => { reportable_id: 1, reportable_type: "DiaryEntry", reported_user_id: 1} }
-    end
+    # Reopen issue without login
+    get :reopen, :params => { :id => issue.id }
     assert_response :redirect
+    assert_redirected_to login_path(:referer => reopen_issue_path(issue))
 
-    # Login as administrator
-    session[:user] = users(:administrator_user).id
-   
-    # Test 'Resolved'
-    get :resolve, id: Issue.find_by_reportable_id_and_reportable_type(1,"DiaryEntry").id
-    assert_equal Issue.find_by_reportable_id_and_reportable_type(1,"DiaryEntry").resolved?, true
+    # Reopen issue as normal user
+    session[:user] = create(:user).id
+    get :reopen, :params => { :id => issue.id }
     assert_response :redirect
+    assert_redirected_to :controller => :errors, :action => :forbidden
 
-    # Test 'Reopen'
-    get :reopen, id: Issue.find_by_reportable_id_and_reportable_type(1,"DiaryEntry").id
-    assert_equal Issue.find_by_reportable_id_and_reportable_type(1,"DiaryEntry").open?, true
+    # Reopen issue as administrator
+    session[:user] = create(:administrator_user).id
+    get :reopen, :params => { :id => issue.id }
     assert_response :redirect
+    assert_equal true, issue.reload.open?
+
+    issue.resolve!
 
-    # Test 'Ignored'
-    get :ignore, id: Issue.find_by_reportable_id_and_reportable_type(1,"DiaryEntry").id
-    assert_equal Issue.find_by_reportable_id_and_reportable_type(1,"DiaryEntry").ignored?, true
+    # Reopen issue as moderator
+    session[:user] = create(:moderator_user).id
+    get :reopen, :params => { :id => issue.id }
     assert_response :redirect
+    assert_equal true, issue.reload.open?
   end
-
 end