X-Git-Url: https://git.openstreetmap.org./rails.git/blobdiff_plain/fb81107b6e953bf8b55a766dc72266dd7d762269..bd1f568c0a91d8d58b05912fdae1a6912edd3e62:/.rubocop_todo.yml?ds=sidebyside diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index d763c6d46..9874aa379 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2023-01-03 19:11:30 UTC using RuboCop version 1.42.0. +# on 2023-04-11 16:47:05 UTC using RuboCop version 1.50.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -14,15 +14,20 @@ require: - rubocop-rails - rubocop-rake -# Offense count: 556 +# Offense count: 11 +# Configuration parameters: Include, MaxAmount +FactoryBot/ExcessiveCreateList: + MaxAmount: 200 + +# Offense count: 557 # This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns. +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns. # URISchemes: http, https Layout/LineLength: Max: 248 # Offense count: 29 -# This cop supports safe autocorrection (--autocorrect). +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Exclude: @@ -42,13 +47,13 @@ Lint/AssignmentInCondition: - 'lib/osm.rb' - 'script/deliver-message' -# Offense count: 681 -# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, CountRepeatedAttributes. +# Offense count: 680 +# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes. Metrics/AbcSize: Max: 189 # Offense count: 73 -# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods. +# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. # AllowedMethods: refine Metrics/BlockLength: Max: 71 @@ -58,18 +63,18 @@ Metrics/BlockLength: Metrics/BlockNesting: Max: 5 -# Offense count: 25 +# Offense count: 26 # Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 316 + Max: 305 -# Offense count: 60 -# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods. +# Offense count: 59 +# Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/CyclomaticComplexity: - Max: 26 + Max: 29 -# Offense count: 755 -# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods. +# Offense count: 753 +# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. Metrics/MethodLength: Max: 179 @@ -78,30 +83,20 @@ Metrics/MethodLength: Metrics/ParameterLists: Max: 6 -# Offense count: 57 -# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods. +# Offense count: 56 +# Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/PerceivedComplexity: - Max: 27 + Max: 30 -# Offense count: 2513 +# Offense count: 2394 # This cop supports safe autocorrection (--autocorrect). Minitest/EmptyLineBeforeAssertionMethods: Enabled: false -# Offense count: 564 +# Offense count: 565 Minitest/MultipleAssertions: Max: 54 -# Offense count: 1 -# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. -# NamePrefix: is_, has_, have_ -# ForbiddenPrefixes: is_, has_, have_ -# AllowedMethods: is_a? -# MethodDefinitionMacros: define_method, define_singleton_method -Naming/PredicateName: - Exclude: - - 'app/models/user.rb' - # Offense count: 1 # This cop supports unsafe autocorrection (--autocorrect-all). Rails/ActionControllerFlashBeforeRender: @@ -172,6 +167,17 @@ Rails/OutputSafety: - 'lib/rich_text.rb' - 'test/helpers/application_helper_test.rb' +# Offense count: 16 +# Configuration parameters: Include. +# Include: db/**/*.rb +Rails/ThreeStateBooleanColumn: + Exclude: + - 'db/migrate/001_create_osm_db.rb' + - 'db/migrate/006_tile_nodes.rb' + - 'db/migrate/007_add_relations.rb' + - 'db/migrate/054_refactor_map_bug_tables.rb' + - 'db/migrate/20140507110937_create_changeset_comments.rb' + # Offense count: 6 # This cop supports safe autocorrection (--autocorrect). Rake/Desc: @@ -181,7 +187,7 @@ Rake/Desc: - 'lib/tasks/subscribe_diary_authors.rake' - 'lib/tasks/subscribe_old_changesets.rake' -# Offense count: 631 +# Offense count: 632 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never @@ -193,10 +199,3 @@ Style/FrozenStringLiteralComment: # Configuration parameters: Strict, AllowedNumbers, AllowedPatterns. Style/NumericLiterals: MinDigits: 15 - -# Offense count: 110 -# This cop supports unsafe autocorrection (--autocorrect-all). -# Configuration parameters: . -# SupportedOperators: *, +, &, |, ^ -Style/YodaExpression: - Enabled: false