]> git.openstreetmap.org Git - rails.git/commit
Rename Feeds::ChangesetCommentsController to ChangesetComments::FeedsController
authorAndy Allan <git@gravitystorm.co.uk>
Wed, 28 Aug 2024 17:18:26 +0000 (18:18 +0100)
committerAndy Allan <git@gravitystorm.co.uk>
Wed, 28 Aug 2024 17:31:36 +0000 (18:31 +0100)
commit10a4c5cf6e1165a9db6e9b87d0fa19d7f97b51bf
tree24b412991088853dd516a205c2d8a88e8c3af363
parenta948f2bc24be0679a42bbd1329d132d9ea20f866
Rename Feeds::ChangesetCommentsController to ChangesetComments::FeedsController

We usually create nested controllers with the main controller as the module,
and the nested controller as the specialization, e.g. Users::DeletionsController
or Traces::IconsController.

This then leaves the topic of whether the feed resource is plural, and whether we
are then showing a singular feed or showing a list (index) of objects.

The routes are carefully named so that we have `changesets_comments_feed_path` (the
comments feed for all changesets) vs `changeset_comment_feed_path(changeset)` (the
comments for a singular changeset).
app/abilities/ability.rb
app/controllers/changeset_comments/feeds_controller.rb [moved from app/controllers/feeds/changeset_comments_controller.rb with 91% similarity]
app/views/changeset_comments/feeds/_comment.html.erb [moved from app/views/feeds/changeset_comments/_comment.html.erb with 100% similarity]
app/views/changeset_comments/feeds/_comment.rss.builder [moved from app/views/feeds/changeset_comments/_comment.rss.builder with 100% similarity]
app/views/changeset_comments/feeds/show.rss.builder [moved from app/views/feeds/changeset_comments/index.rss.builder with 100% similarity]
app/views/changeset_comments/feeds/timeout.atom.builder [moved from app/views/feeds/changeset_comments/timeout.atom.builder with 100% similarity]
app/views/changeset_comments/feeds/timeout.html.erb [moved from app/views/feeds/changeset_comments/timeout.html.erb with 100% similarity]
config/locales/en.yml
config/routes.rb
test/controllers/changeset_comments/feeds_controller_test.rb [moved from test/controllers/feeds/changeset_comments_controller_test.rb with 74% similarity]