]> git.openstreetmap.org Git - rails.git/commit
projects / rails.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: c8fc221) | patch
Prefer find_by() instead of where().first
authorAndy Allan <git@gravitystorm.co.uk>
Wed, 4 Oct 2023 16:53:58 +0000 (17:53 +0100)
committerAndy Allan <git@gravitystorm.co.uk>
Wed, 4 Oct 2023 16:53:58 +0000 (17:53 +0100)
commit1700c23dd1018b66a268b4c76fcf9fb2a09a35ab
treebc5409c827859066775baab5a52000d1721e7b3btree | snapshot
parentc8fc2218e5e342ad7afc9409974fd48a733ba94bcommit | diff
Prefer find_by() instead of where().first

These are very similar, differing only if we would expect multiple
results and the sorting is important. However, in all our cases
we're only expecting one result to be returned, and so find_by is
easier to read.
.rubocop.yml diff | blob | history
app/controllers/api/traces_controller.rb diff | blob | history
app/controllers/application_controller.rb diff | blob | history
app/controllers/diary_entries_controller.rb diff | blob | history
app/controllers/traces_controller.rb diff | blob | history
test/controllers/api/traces_controller_test.rb diff | blob | history
test/controllers/diary_entries_controller_test.rb diff | blob | history
test/controllers/friendships_controller_test.rb diff | blob | history
test/controllers/traces_controller_test.rb diff | blob | history
test/models/node_test.rb diff | blob | history
test/models/trace_test.rb diff | blob | history
The OpenStreetMap web site