Improve character validator error messages

diff --git a/app/validators/characters_validator.rb b/app/validators/characters_validator.rb
index cbcd03a16df5034ee3f350916a3501073fb2c4ba..ee5b1206a08354c3406e2e383c331fe1089c23bf 100644 (file)
--- a/app/validators/characters_validator.rb
+++ b/app/validators/characters_validator.rb
@@ -3,10 +3,10 @@ class CharactersValidator < ActiveModel::EachValidator
   INVALID_URL_CHARS = "/;.,?%#".freeze
 
   def validate_each(record, attribute, value)
   INVALID_URL_CHARS = "/;.,?%#".freeze
 
   def validate_each(record, attribute, value)

-    record.errors[attribute] << (options[:message] || I18n.t("validations.invalid_chars")) if value =~ /[#{INVALID_CHARS}]/
+    record.errors[attribute] << (options[:message] || I18n.t("validations.invalid_characters")) if value =~ /[#{INVALID_CHARS}]/

 
     if options[:url_safe]
 
     if options[:url_safe]

-      record.errors[attribute] << (options[:message] || I18n.t("validations.invalid_url_chars", :invalid_url_chars => INVALID_URL_CHARS)) if value =~ /[#{INVALID_URL_CHARS}]/
+      record.errors[attribute] << (options[:message] || I18n.t("validations.url_characters", :characters => INVALID_URL_CHARS)) if value =~ /[#{INVALID_URL_CHARS}]/

     end
   end
 end
     end
   end
 end

diff --git a/config/locales/en.yml b/config/locales/en.yml
index 112f3a207a56e3496a4d91418b24a5abe4a326a9..a9370018aabba1ad6ddecff6fdd0f786c208f044 100644 (file)
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -2565,5 +2565,5 @@ en:
   validations:
     leading_whitespace: "has leading whitespace"
     trailing_whitespace: "has trailing whitespace"
   validations:
     leading_whitespace: "has leading whitespace"
     trailing_whitespace: "has trailing whitespace"

-    invalid_chars: "contains invalid chars"
-    invalid_url_chars: "must not contain an invalid char: %{invalid_url_chars}"
+    invalid_characters: "contains invalid characters"
+    url_characters: "contains special URL characters (%{characters})"