Wait for the button to be disabled, before checking the tooltip behaviour

Rather than sleeping for a fixed period, we can use Capybara's built-in
ability to wait for elements to be present. Since we're only changing
the state of existing elements though, we need to wait for their
"disabled" property to be set.

Fixes some timing-related problems with the test suite.

diff --git a/test/system/site_test.rb b/test/system/site_test.rb
index 0fa524675ce3cc68200d18de43a2e9e472be3926..d7b9f279e9d3d874ca3240d604749efa9e25173f 100644 (file)
--- a/test/system/site_test.rb
+++ b/test/system/site_test.rb
@@ -71,9 +71,10 @@ class SiteTest < ApplicationSystemTestCase
       find("h1").hover # un-hover original element
 
       visit "#map=10/0/0"
       find("h1").hover # un-hover original element
 
       visit "#map=10/0/0"

+      find("#{selector}.disabled") # Ensure that capybara has waited for JS to finish processing
+

       assert_no_selector ".tooltip"
       find(selector).hover
       assert_no_selector ".tooltip"
       find(selector).hover

-      sleep(0.5)

       assert_selector ".tooltip", :text => "Zoom in"
     end
   end
       assert_selector ".tooltip", :text => "Zoom in"
     end
   end