Small improvement to block status display

diff --git a/app/helpers/user_blocks_helper.rb b/app/helpers/user_blocks_helper.rb
index 282d9164aa2cc046842b23939a8a6db557696fbe..3c9c0a37e5f6a5d1ab237505e9835a75e844d865 100644 (file)
--- a/app/helpers/user_blocks_helper.rb
+++ b/app/helpers/user_blocks_helper.rb
@@ -4,8 +4,13 @@ module UserBlocksHelper
   # user block (i.e: whether it's active, what the expiry time is)
   def block_status(block)
     if block.active?
   # user block (i.e: whether it's active, what the expiry time is)
   def block_status(block)
     if block.active?

+      # if the block hasn't expired yet show the date, if the user just needs to login show that

       if block.needs_view?
       if block.needs_view?

-        I18n.t("user_block.helper.until_login")
+        if block.ends_at > Time.now.getutc
+          I18n.t("user_block.helper.time_future_and_until_login", :time => friendly_date(block.ends_at)).html_safe
+        else
+          I18n.t("user_block.helper.until_login")
+        end

       else
         I18n.t("user_block.helper.time_future", :time => friendly_date(block.ends_at)).html_safe
       end
       else
         I18n.t("user_block.helper.time_future", :time => friendly_date(block.ends_at)).html_safe
       end

diff --git a/config/locales/en.yml b/config/locales/en.yml
index b2ebffd61a273f7d4d329886ca0c07b8b6a34272..757e74e63b4098ed497003176ddd0ff40432caa2 100644 (file)
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -2112,6 +2112,7 @@ en:
     helper:
       time_future: "Ends in %{time}."
       until_login: "Active until the user logs in."
     helper:
       time_future: "Ends in %{time}."
       until_login: "Active until the user logs in."

+      time_future_and_until_login: "Expires in %{time} and requires the user to login."

       time_past: "Ended %{time} ago."
     blocks_on:
       title: "Blocks on %{name}"
       time_past: "Ended %{time} ago."
     blocks_on:
       title: "Blocks on %{name}"