Change tests to expect a successful (empty) response even if the user is not visible...

diff --git a/test/controllers/api/users_controller_test.rb b/test/controllers/api/users_controller_test.rb
index cb2c7520504dfa38f0c51cde7434cfafb4a15834..e62f338392c6f7798c41ef7d98d5429bc4743656 100644 (file)
--- a/test/controllers/api/users_controller_test.rb
+++ b/test/controllers/api/users_controller_test.rb
@@ -419,13 +419,15 @@ module Api
       check_json_details(js["users"][1], user3, false, false)
 
       get api_users_path, :params => { :users => create(:user, :suspended).id }
       check_json_details(js["users"][1], user3, false, false)
 
       get api_users_path, :params => { :users => create(:user, :suspended).id }

-      assert_response :not_found
+      assert_response :success

 
       get api_users_path, :params => { :users => create(:user, :deleted).id }
 
       get api_users_path, :params => { :users => create(:user, :deleted).id }

-      assert_response :not_found
+      assert_response :success

 
       get api_users_path, :params => { :users => 0 }
 
       get api_users_path, :params => { :users => 0 }

-      assert_response :not_found
+      assert_response :success
+      assert_equal "application/xml", response.media_type
+      assert_select "user", :count => 0

     end
 
     def test_index_oauth1
     end
 
     def test_index_oauth1


@@ -506,13 +508,15 @@ module Api
       check_json_details(js["users"][1], user3, false, false)
 
       signed_get api_users_path, :params => { :users => create(:user, :suspended).id }, :oauth => { :token => good_token }
       check_json_details(js["users"][1], user3, false, false)
 
       signed_get api_users_path, :params => { :users => create(:user, :suspended).id }, :oauth => { :token => good_token }

-      assert_response :not_found
+      assert_response :success

 
       signed_get api_users_path, :params => { :users => create(:user, :deleted).id }, :oauth => { :token => good_token }
 
       signed_get api_users_path, :params => { :users => create(:user, :deleted).id }, :oauth => { :token => good_token }

-      assert_response :not_found
+      assert_response :success

 
       signed_get api_users_path, :params => { :users => 0 }, :oauth => { :token => good_token }
 
       signed_get api_users_path, :params => { :users => 0 }, :oauth => { :token => good_token }

-      assert_response :not_found
+      assert_response :success
+      assert_equal "application/xml", response.media_type
+      assert_select "user", :count => 0

     end
 
     def test_index_oauth2
     end
 
     def test_index_oauth2


@@ -593,13 +597,15 @@ module Api
       check_json_details(js["users"][1], user3, false, false)
 
       get api_users_path, :params => { :users => create(:user, :suspended).id }, :headers => bearer_authorization_header(good_token.token)
       check_json_details(js["users"][1], user3, false, false)
 
       get api_users_path, :params => { :users => create(:user, :suspended).id }, :headers => bearer_authorization_header(good_token.token)

-      assert_response :not_found
+      assert_response :success

 
       get api_users_path, :params => { :users => create(:user, :deleted).id }, :headers => bearer_authorization_header(good_token.token)
 
       get api_users_path, :params => { :users => create(:user, :deleted).id }, :headers => bearer_authorization_header(good_token.token)

-      assert_response :not_found
+      assert_response :success

 
       get api_users_path, :params => { :users => 0 }, :headers => bearer_authorization_header(good_token.token)
 
       get api_users_path, :params => { :users => 0 }, :headers => bearer_authorization_header(good_token.token)

-      assert_response :not_found
+      assert_response :success
+      assert_equal "application/xml", response.media_type
+      assert_select "user", :count => 0

     end
 
     def test_gpx_files
     end
 
     def test_gpx_files