Fix new rubocop warnings

diff --git a/lib/short_link.rb b/lib/short_link.rb
index 424e85c1095999e781147f35610193b36ade59e0..8983f3bd3bd1c4858d5aab8caa57a538d12b32a7 100644 (file)
--- a/lib/short_link.rb
+++ b/lib/short_link.rb
@@ -32,11 +32,11 @@ module ShortLink
         else
           3.times do
             x <<= 1
         else
           3.times do
             x <<= 1

-            x |= 1 unless (t & 32).zero?
+            x |= 1 unless t.nobits?(32)

             t <<= 1
 
             y <<= 1
             t <<= 1
 
             y <<= 1

-            y |= 1 unless (t & 32).zero?
+            y |= 1 unless t.nobits?(32)

             t <<= 1
           end
           z += 3
             t <<= 1
           end
           z += 3

diff --git a/test/controllers/api/relations_controller_test.rb b/test/controllers/api/relations_controller_test.rb
index 6cbfe6045f48f656b7b9037cb0e25741fdf3789c..5fb62d29f52550b5329581569b2329c035fcedbd 100644 (file)
--- a/test/controllers/api/relations_controller_test.rb
+++ b/test/controllers/api/relations_controller_test.rb
@@ -1066,7 +1066,7 @@ module Api
 
       # create a new changeset for this operation, so we are assured
       # that the bounding box will be newly-generated.
 
       # create a new changeset for this operation, so we are assured
       # that the bounding box will be newly-generated.

-      changeset_id = with_controller(Api::ChangesetsController.new) do
+      with_controller(Api::ChangesetsController.new) do

         xml = "<osm><changeset/></osm>"
         put changeset_create_path, :params => xml, :headers => auth_header
         assert_response :forbidden, "shouldn't be able to create changeset for modify test, as should get forbidden"
         xml = "<osm><changeset/></osm>"
         put changeset_create_path, :params => xml, :headers => auth_header
         assert_response :forbidden, "shouldn't be able to create changeset for modify test, as should get forbidden"