From: Nenad Vujicic <nenadus@gmail.com>
Date: Tue, 4 Mar 2025 15:04:45 +0000 (+0100)
Subject: Updates note_comments and notes factories
X-Git-Tag: live~2^2~1
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/047e972b2d448ade83382c0f824cb6e123b9bacb

Updates note_comments and notes factories

Updates note_comments factory to create "commented" note comments by default. Improves notes factory to set note's description to "Default note's description" by default and to set first note's comment type to "opened" when used note_with_comments.
---

diff --git a/test/factories/note_comments.rb b/test/factories/note_comments.rb
index da51c0228..a6d7b5328 100644
--- a/test/factories/note_comments.rb
+++ b/test/factories/note_comments.rb
@@ -2,7 +2,7 @@ FactoryBot.define do
   factory :note_comment do
     sequence(:body) { |n| "This is note comment #{n}" }
     visible { true }
-    event { "opened" }
+    event { "commented" }
     note
   end
 end
diff --git a/test/factories/notes.rb b/test/factories/notes.rb
index ab7d5df56..268a2bfb7 100644
--- a/test/factories/notes.rb
+++ b/test/factories/notes.rb
@@ -2,7 +2,7 @@ FactoryBot.define do
   factory :note do
     latitude { 1 * GeoRecord::SCALE }
     longitude { 1 * GeoRecord::SCALE }
-    # tile { QuadTile.tile_for_point(1,1) }
+    description { "Default note's description" }
 
     trait :closed do
       transient do
@@ -23,7 +23,8 @@ FactoryBot.define do
       end
 
       after(:create) do |note, evaluator|
-        create_list(:note_comment, evaluator.comments_count, :note => note)
+        create(:note_comment, :event => "opened", :note => note)
+        create_list(:note_comment, evaluator.comments_count - 1, :note => note)
       end
     end
   end