From: Martin Raifer <martin@raifer.tech>
Date: Wed, 12 Feb 2025 13:08:19 +0000 (+0100)
Subject: workaround for iD bug #10761
X-Git-Tag: live~188^2~2
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/051ae5953f18e2bcc4a4612e9851c95c0f86842e

workaround for iD bug #10761

the current version of iD (v2.31, before the fix for https://github.com/openstreetmap/iD/issue/10761: https://github.com/openstreetmap/iD/pull/10766), does not fully support `x-www-form-urlencoded` "query-style" strings in the hash: Specifically, spaces encoded as `+` will not be decoded back to ` `.

This workaround essentially temporarily reverts the behaviour of the website to the state before #5592, and can be dropped again with the next minor version upgrade of iD (`v2.32`).
---

diff --git a/app/assets/javascripts/edit/id.js.erb b/app/assets/javascripts/edit/id.js.erb
index 588aa1e86..637b414c3 100644
--- a/app/assets/javascripts/edit/id.js.erb
+++ b/app/assets/javascripts/edit/id.js.erb
@@ -33,5 +33,5 @@ $(document).ready(function () {
 
   if (id.data("gpx")) params.set("gpx", id.data("gpx"));
 
-  id.attr("src", id.data("url") + "#" + params);
+  id.attr("src", id.data("url") + "#" + params.toString().replace('+', '%20'));
 });