From: Andy Allan <git@gravitystorm.co.uk>
Date: Wed, 26 Jul 2023 16:39:36 +0000 (+0100)
Subject: Simplify menu-icon css
X-Git-Tag: live~1190^2
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/0a66990911baf62807d6bd50b8d0885a227c6e09?ds=sidebyside

Simplify menu-icon css

Remove the duplicate display property, since it was force-overridden
by the `!important` keyword in the same definiton. This then makes the
`!important` keywords unnecessary. The menu-icon is floated, and
therefore can't be `inline-block`, so browsers were interpreting that
as `block` all along.
---

diff --git a/app/assets/stylesheets/common.scss b/app/assets/stylesheets/common.scss
index 853b79938..19cc8e5be 100644
--- a/app/assets/stylesheets/common.scss
+++ b/app/assets/stylesheets/common.scss
@@ -80,11 +80,10 @@ small, aside {
 /* Rules for the header */
 
 #menu-icon {
-  display: none !important;
+  display: none;
   float: right;
   background: image-url("menu-icon.png") no-repeat;
   background-size: 30px 30px;
-  display: block;
   width: 30px;
   height: 30px;
   margin: 14px 10px 0 0;
@@ -244,7 +243,7 @@ body.compact-nav {
 
 body.small-nav {
   #menu-icon {
-    display: inline-block !important;
+    display: block;
   }
 
   nav.primary,