From: Anton Khorev <tony29@yandex.ru>
Date: Sat, 1 Feb 2025 12:13:09 +0000 (+0300)
Subject: Split api relation show/full tests
X-Git-Tag: live~211^2~4
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/0c893e91970da4ac70e77de435c4906ab260b855?ds=sidebyside;hp=--cc

Split api relation show/full tests
---

0c893e91970da4ac70e77de435c4906ab260b855
diff --git a/test/controllers/api/relations_controller_test.rb b/test/controllers/api/relations_controller_test.rb
index cde794852..040062153 100644
--- a/test/controllers/api/relations_controller_test.rb
+++ b/test/controllers/api/relations_controller_test.rb
@@ -122,29 +122,33 @@ module Api
     # Test showing relations.
     # -------------------------------------
 
-    def test_show
-      # check that a visible relation is returned properly
-      get api_relation_path(create(:relation))
-      assert_response :success
+    def test_show_not_found
+      get api_relation_path(0)
+      assert_response :not_found
+    end
 
-      # check that an invisible relation is not returned
+    def test_show_deleted
       get api_relation_path(create(:relation, :deleted))
       assert_response :gone
+    end
 
-      # check chat a non-existent relation is not returned
-      get api_relation_path(0)
-      assert_response :not_found
+    def test_show
+      get api_relation_path(create(:relation))
+      assert_response :success
     end
 
-    def test_full
-      # check the "full" mode
-      get relation_full_path(:id => 999999)
+    def test_full_not_found
+      get relation_full_path(999999)
       assert_response :not_found
+    end
 
-      get relation_full_path(:id => create(:relation, :deleted).id)
+    def test_full_deleted
+      get relation_full_path(create(:relation, :deleted))
       assert_response :gone
+    end
 
-      get relation_full_path(:id => create(:relation).id)
+    def test_full_empty
+      get relation_full_path(create(:relation))
       assert_response :success
       # FIXME: check whether this contains the stuff we want!
     end