From: Andy Allan <git@gravitystorm.co.uk>
Date: Wed, 15 Jan 2020 11:09:06 +0000 (+0100)
Subject: Minor tweaks to copyright heading
X-Git-Tag: live~2798^2
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/1a75b1ba72090d33249d5238bdda81b30fbd59fe

Minor tweaks to copyright heading

This fixes a small bug where the hr was shown even when not required,
by ensuring the test is run before creating the content.

Also fixes where an h1 tag was used instead of a div.
---

diff --git a/app/views/site/copyright.html.erb b/app/views/site/copyright.html.erb
index 75f4e878d..a8506e902 100644
--- a/app/views/site/copyright.html.erb
+++ b/app/views/site/copyright.html.erb
@@ -3,7 +3,7 @@
   <!-- Maybe ease foreigners back to their native page -->
 
     <% if t(".legal_babble", :locale => I18n.locale) != t(".legal_babble", :locale => :en) %>
-      <%= tag.h1 :lang => @locale, :dir => t("html.dir", :locale => @locale) do %>
+      <%= tag.div :lang => @locale, :dir => t("html.dir", :locale => @locale) do %>
         <h1><%= t ".native.title" %></h1>
         <p>
           <%= t ".native.html",
@@ -20,8 +20,8 @@
     <% end %>
   <% else %>
     <!-- Maybe note that this page has been translated -->
-    <%= tag.div :lang => "en", :dir => t("html.dir", :locale => "en") do %>
-      <% if t(".legal_babble", :locale => @locale) != t(".legal_babble", :locale => :en) %>
+    <% if t(".legal_babble", :locale => @locale) != t(".legal_babble", :locale => :en) %>
+      <%= tag.div :lang => "en", :dir => t("html.dir", :locale => "en") do %>
         <h1><%= t ".foreign.title" %></h1>
         <p>
           <%= t ".foreign.html",