From: Anton Khorev <tony29@yandex.ru>
Date: Thu, 19 Sep 2024 12:58:07 +0000 (+0300)
Subject: Don't use ?: in "Comment from user" changeset discussion strings
X-Git-Tag: live~173^2
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/1c88a0b136de0d7bf43b66912b618e3e9e83db91

Don't use ?: in "Comment from user" changeset discussion strings
---

diff --git a/app/views/changesets/show.html.erb b/app/views/changesets/show.html.erb
index 13f40ce50..a47049e99 100644
--- a/app/views/changesets/show.html.erb
+++ b/app/views/changesets/show.html.erb
@@ -40,9 +40,9 @@
         <% next unless comment.visible || current_user&.moderator? %>
         <li id="c<%= comment.id %>">
           <small class='text-body-secondary'>
-            <%= t comment.visible ? ".comment_by_html" : ".hidden_comment_by_html",
-                  :time_ago => friendly_date_ago(comment.created_at),
-                  :user => link_to(comment.author.display_name, comment.author) %>
+            <%= comment_by_options = { :time_ago => friendly_date_ago(comment.created_at),
+                                       :user => link_to(comment.author.display_name, comment.author) }
+                comment.visible ? t(".comment_by_html", **comment_by_options) : t(".hidden_comment_by_html", **comment_by_options) %>
             <% if current_user&.moderator? %>
               —
               <%= tag.button t(".#{comment.visible ? 'hide' : 'unhide'}_comment"),