From: Anton Khorev <tony29@yandex.ru>
Date: Mon, 6 Jan 2025 15:58:55 +0000 (+0300)
Subject: Move browse/feature template to elements/show
X-Git-Tag: live~23^2
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/23488f202877621ed27e74826848d5a4d518d867

Move browse/feature template to elements/show
---

diff --git a/app/controllers/nodes_controller.rb b/app/controllers/nodes_controller.rb
index 7469b8a86..0ef07dbbf 100644
--- a/app/controllers/nodes_controller.rb
+++ b/app/controllers/nodes_controller.rb
@@ -2,7 +2,6 @@ class NodesController < ElementsController
   def show
     @type = "node"
     @feature = Node.preload(:node_tags, :containing_relation_members, :changeset => [:changeset_tags, :user], :ways => :way_tags).find(params[:id])
-    render "browse/feature"
   rescue ActiveRecord::RecordNotFound
     render "browse/not_found", :status => :not_found
   end
diff --git a/app/controllers/relations_controller.rb b/app/controllers/relations_controller.rb
index 06ee785f0..9199c9e4a 100644
--- a/app/controllers/relations_controller.rb
+++ b/app/controllers/relations_controller.rb
@@ -2,7 +2,6 @@ class RelationsController < ElementsController
   def show
     @type = "relation"
     @feature = Relation.preload(:relation_tags, :containing_relation_members, :changeset => [:changeset_tags, :user], :relation_members => :member).find(params[:id])
-    render "browse/feature"
   rescue ActiveRecord::RecordNotFound
     render "browse/not_found", :status => :not_found
   end
diff --git a/app/controllers/ways_controller.rb b/app/controllers/ways_controller.rb
index bf45cca63..d5c5d8736 100644
--- a/app/controllers/ways_controller.rb
+++ b/app/controllers/ways_controller.rb
@@ -2,7 +2,6 @@ class WaysController < ElementsController
   def show
     @type = "way"
     @feature = Way.preload(:way_tags, :containing_relation_members, :changeset => [:changeset_tags, :user], :nodes => [:node_tags, { :ways => :way_tags }]).find(params[:id])
-    render "browse/feature"
   rescue ActiveRecord::RecordNotFound
     render "browse/not_found", :status => :not_found
   end
diff --git a/app/views/browse/feature.html.erb b/app/views/elements/show.html.erb
similarity index 100%
rename from app/views/browse/feature.html.erb
rename to app/views/elements/show.html.erb
diff --git a/test/controllers/nodes_controller_test.rb b/test/controllers/nodes_controller_test.rb
index a29432723..6db340c21 100644
--- a/test/controllers/nodes_controller_test.rb
+++ b/test/controllers/nodes_controller_test.rb
@@ -12,7 +12,7 @@ class NodesControllerTest < ActionDispatch::IntegrationTest
 
   def test_show
     node = create(:node)
-    sidebar_browse_check :node_path, node.id, "browse/feature"
+    sidebar_browse_check :node_path, node.id, "elements/show"
     assert_select "h4", /^Version/ do
       assert_select "a[href='#{old_node_path node, 1}']", :text => "1", :count => 1
     end
@@ -23,7 +23,7 @@ class NodesControllerTest < ActionDispatch::IntegrationTest
 
   def test_show_multiple_versions
     node = create(:node, :with_history, :version => 2)
-    sidebar_browse_check :node_path, node.id, "browse/feature"
+    sidebar_browse_check :node_path, node.id, "elements/show"
     assert_select ".secondary-actions a[href='#{node_history_path node}']", :count => 1
     assert_select ".secondary-actions a[href='#{old_node_path node, 1}']", :count => 1
     assert_select ".secondary-actions a[href='#{old_node_path node, 2}']", :count => 1
@@ -33,13 +33,13 @@ class NodesControllerTest < ActionDispatch::IntegrationTest
     member = create(:node)
     relation = create(:relation)
     create(:relation_member, :relation => relation, :member => member)
-    sidebar_browse_check :node_path, member.id, "browse/feature"
+    sidebar_browse_check :node_path, member.id, "elements/show"
     assert_select "a[href='#{relation_path relation}']", :count => 1
   end
 
   def test_show_deleted
     node = create(:node, :visible => false)
-    sidebar_browse_check :node_path, node.id, "browse/feature"
+    sidebar_browse_check :node_path, node.id, "elements/show"
     assert_select "h4", /^Version/ do
       assert_select "a[href='#{old_node_path node, 1}']", :text => "1", :count => 1
     end
@@ -53,7 +53,7 @@ class NodesControllerTest < ActionDispatch::IntegrationTest
 
     get node_path(node)
     assert_response :success
-    assert_template "feature"
+    assert_template "elements/show"
 
     # check that we don't show lat/lon for a redacted node.
     assert_select ".browse-section", 1
diff --git a/test/controllers/relations_controller_test.rb b/test/controllers/relations_controller_test.rb
index bdcbd2fd7..0f07a1a4a 100644
--- a/test/controllers/relations_controller_test.rb
+++ b/test/controllers/relations_controller_test.rb
@@ -12,7 +12,7 @@ class RelationsControllerTest < ActionDispatch::IntegrationTest
 
   def test_show
     relation = create(:relation)
-    sidebar_browse_check :relation_path, relation.id, "browse/feature"
+    sidebar_browse_check :relation_path, relation.id, "elements/show"
     assert_select "h4", /^Version/ do
       assert_select "a[href='#{old_relation_path relation, 1}']", :text => "1", :count => 1
     end
@@ -23,7 +23,7 @@ class RelationsControllerTest < ActionDispatch::IntegrationTest
 
   def test_show_multiple_versions
     relation = create(:relation, :with_history, :version => 2)
-    sidebar_browse_check :relation_path, relation.id, "browse/feature"
+    sidebar_browse_check :relation_path, relation.id, "elements/show"
     assert_select ".secondary-actions a[href='#{relation_history_path relation}']", :count => 1
     assert_select ".secondary-actions a[href='#{old_relation_path relation, 1}']", :count => 1
     assert_select ".secondary-actions a[href='#{old_relation_path relation, 2}']", :count => 1
@@ -33,7 +33,7 @@ class RelationsControllerTest < ActionDispatch::IntegrationTest
     member = create(:relation)
     relation = create(:relation)
     create(:relation_member, :relation => relation, :member => member)
-    sidebar_browse_check :relation_path, member.id, "browse/feature"
+    sidebar_browse_check :relation_path, member.id, "elements/show"
     assert_select "a[href='#{relation_path relation}']", :count => 1
   end
 
diff --git a/test/controllers/ways_controller_test.rb b/test/controllers/ways_controller_test.rb
index 995004cb4..5b80a070c 100644
--- a/test/controllers/ways_controller_test.rb
+++ b/test/controllers/ways_controller_test.rb
@@ -12,7 +12,7 @@ class WaysControllerTest < ActionDispatch::IntegrationTest
 
   def test_show
     way = create(:way)
-    sidebar_browse_check :way_path, way.id, "browse/feature"
+    sidebar_browse_check :way_path, way.id, "elements/show"
     assert_select "h4", /^Version/ do
       assert_select "a[href='#{old_way_path way, 1}']", :text => "1", :count => 1
     end
@@ -23,7 +23,7 @@ class WaysControllerTest < ActionDispatch::IntegrationTest
 
   def test_show_multiple_versions
     way = create(:way, :with_history, :version => 2)
-    sidebar_browse_check :way_path, way.id, "browse/feature"
+    sidebar_browse_check :way_path, way.id, "elements/show"
     assert_select ".secondary-actions a[href='#{way_history_path way}']", :count => 1
     assert_select ".secondary-actions a[href='#{old_way_path way, 1}']", :count => 1
     assert_select ".secondary-actions a[href='#{old_way_path way, 2}']", :count => 1
@@ -33,7 +33,7 @@ class WaysControllerTest < ActionDispatch::IntegrationTest
     member = create(:way)
     relation = create(:relation)
     create(:relation_member, :relation => relation, :member => member)
-    sidebar_browse_check :way_path, member.id, "browse/feature"
+    sidebar_browse_check :way_path, member.id, "elements/show"
     assert_select "a[href='#{relation_path relation}']", :count => 1
   end