From: Tom Hughes
Date: Sat, 21 Aug 2021 14:32:47 +0000 (+0100)
Subject: Improve behaviour of secondary action lists when wrapping
X-Git-Tag: live~1933^2~6^2
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/29e98571454a450f0af1e2649d1688c6f2afffdb?ds=sidebyside;hp=-c
Improve behaviour of secondary action lists when wrapping
Based on https://stackoverflow.com/a/31732902 this ensure that when
a secondary action list wraps the additional lines don't start with
an item delimiter by pushing it to the left, outside of a parent nav
element which then hides it.
---
29e98571454a450f0af1e2649d1688c6f2afffdb
diff --git a/app/assets/stylesheets/common.scss b/app/assets/stylesheets/common.scss
index 16624dda1..ec2ec4dea 100644
--- a/app/assets/stylesheets/common.scss
+++ b/app/assets/stylesheets/common.scss
@@ -1474,28 +1474,28 @@ abbr.geo {
/* General styles for action lists / subnavs / pager navs */
-ul.secondary-actions {
- font-style: normal;
- margin-bottom: 0;
- margin-left: 0;
- padding: 0;
- &.pager {
- display: inline-block;
- margin-right: 60px;
- }
- > li {
- display: block;
- float: left;
- list-style: none;
- border-left: 1px solid $grey;
- padding-left: $lineheight/2;
- margin-right: $lineheight/2;
- &:first-child {
- border-left: 0;
- padding-left: 0;
+
+nav.secondary-actions {
+ margin-left: -11px;
+ overflow: hidden;
+ > ul {
+ display: flex;
+ flex-direction: row;
+ flex-wrap: wrap;
+ margin-bottom: 0;
+ margin-left: -1px;
+ padding: 0;
+ &.pager {
+ display: inline-block;
+ margin-right: 60px;
}
- &:last-child {
- margin-right: 0px;
+ > li {
+ flex-basis: auto;
+ list-style: none;
+ border-left: 1px solid $grey;
+ padding-left: $lineheight/2;
+ margin-right: $lineheight/2;
+ margin-bottom: $lineheight/8;
}
}
}
diff --git a/app/views/dashboards/_contact.html.erb b/app/views/dashboards/_contact.html.erb
index 3b46a3b45..545557e64 100644
--- a/app/views/dashboards/_contact.html.erb
+++ b/app/views/dashboards/_contact.html.erb
@@ -31,15 +31,17 @@
<% end %>
-
- - <%= link_to t("users.show.send message"), new_message_path(contact) %>
- -
- <% if current_user.is_friends_with?(contact) %>
- <%= link_to t("users.show.remove as friend"), remove_friend_path(:display_name => contact.display_name, :referer => request.fullpath), :method => :post %>
- <% else %>
- <%= link_to t("users.show.add as friend"), make_friend_path(:display_name => contact.display_name, :referer => request.fullpath), :method => :post %>
- <% end %>
-
-
+
<% end %>
diff --git a/app/views/dashboards/show.html.erb b/app/views/dashboards/show.html.erb
index 3fe27b779..f5feb9037 100644
--- a/app/views/dashboards/show.html.erb
+++ b/app/views/dashboards/show.html.erb
@@ -32,10 +32,12 @@
<% if friends.empty? %>
<%= t ".no friends" %>
<% else %>
-
- - <%= link_to t(".friends_changesets"), friend_changesets_path %>
- - <%= link_to t(".friends_diaries"), friends_diary_entries_path %>
-
+
<%= render :partial => "contact", :collection => friends, :locals => { :type => "friend" } %>
@@ -48,10 +50,12 @@
<% if nearby.empty? %>
<%= t ".no nearby users" %>
<% else %>
-
- - <%= link_to t(".nearby_changesets"), nearby_changesets_path %>
- - <%= link_to t(".nearby_diaries"), nearby_diary_entries_path %>
-
+
<%= render :partial => "contact", :collection => nearby, :locals => { :type => "nearby mapper" } %>
diff --git a/app/views/diary_entries/_diary_entry.html.erb b/app/views/diary_entries/_diary_entry.html.erb
index 946c6ce17..4080b8f95 100644
--- a/app/views/diary_entries/_diary_entry.html.erb
+++ b/app/views/diary_entries/_diary_entry.html.erb
@@ -23,31 +23,33 @@
<%= render :partial => "location", :object => diary_entry %>
<% end %>
-
- <% if params[:action] == 'index' %>
- - <%= link_to t(".comment_link"), diary_entry_path(diary_entry.user, diary_entry, :anchor => "newcomment") %>
- - <%= link_to t(".reply_link"), new_message_path(diary_entry.user, :message => { :title => "Re: #{diary_entry.title}" }) %>
- - <%= link_to t(".comment_count", :count => diary_entry.visible_comments.count), diary_entry_path(diary_entry.user, diary_entry, :anchor => "comments") %>
- <% end %>
+
+
diff --git a/app/views/diary_entries/index.html.erb b/app/views/diary_entries/index.html.erb
index 80561cbbf..6803c761e 100644
--- a/app/views/diary_entries/index.html.erb
+++ b/app/views/diary_entries/index.html.erb
@@ -6,19 +6,21 @@
<% end %>
<%= @title %>
-
- <% unless params[:friends] or params[:nearby] -%>
- - <%= rss_link_to :action => "rss", :language => params[:language] %>
- <% end -%>
-
- <% if @user && @user == current_user || !@user && current_user %>
- - <%= link_to image_tag("new.png", :class => "small_icon") + t(".new"), new_diary_entry_path, :title => t(".new_title") %>
- <% end %>
-
- <% if !@user && current_user %>
- - <%= link_to t(".my_diary"), :controller => "diary_entries", :action => "index", :display_name => current_user.display_name %>
- <% end %>
-
+
<% end %>
diff --git a/app/views/traces/_trace.html.erb b/app/views/traces/_trace.html.erb
index 44de2ef06..74e096dd1 100644
--- a/app/views/traces/_trace.html.erb
+++ b/app/views/traces/_trace.html.erb
@@ -44,14 +44,16 @@
<% if trace.inserted? %>
-
- -
- <%= link_to t(".view_map"), { :controller => "site", :action => "index", :mlat => trace.latitude, :mlon => trace.longitude, :anchor => "map=14/#{trace.latitude}/#{trace.longitude}" } %>
-
- -
- <%= link_to t(".edit_map"), { :controller => "site", :action => "edit", :gpx => trace.id } %>
-
-
+
<% end %>
|
diff --git a/app/views/user_blocks/_blocks.html.erb b/app/views/user_blocks/_blocks.html.erb
index 8955852c1..b0b73c5a0 100644
--- a/app/views/user_blocks/_blocks.html.erb
+++ b/app/views/user_blocks/_blocks.html.erb
@@ -20,18 +20,20 @@
<%= render :partial => "block", :locals => { :show_revoke_link => show_revoke_link, :show_user_name => show_user_name, :show_creator_name => show_creator_name }, :collection => @user_blocks %>
-
- <% if @user_blocks_pages.current_page.number > 1 -%>
- - <%= link_to t(".previous"), @params.merge(:page => @user_blocks_pages.current_page.number - 1) %>
- <% else -%>
- - <%= t(".previous") %>
- <% end -%>
+
+
diff --git a/app/views/user_blocks/edit.html.erb b/app/views/user_blocks/edit.html.erb
index 882eb27b1..8c89c80f3 100644
--- a/app/views/user_blocks/edit.html.erb
+++ b/app/views/user_blocks/edit.html.erb
@@ -3,10 +3,12 @@
<%= t(".heading_html",
:name => link_to(@user_block.user.display_name,
user_path(@user_block.user))) %>
-
- - <%= link_to t(".show"), @user_block %>
- - <%= link_to t(".back"), user_blocks_path %>
-
+
<% end %>
<%= bootstrap_form_for(@user_block) do |f| %>
diff --git a/app/views/user_blocks/show.html.erb b/app/views/user_blocks/show.html.erb
index d686bda10..03bcd3036 100644
--- a/app/views/user_blocks/show.html.erb
+++ b/app/views/user_blocks/show.html.erb
@@ -8,17 +8,19 @@
user_path(@user_block.user)),
:block_by => link_to(@user_block.creator.display_name,
user_path(@user_block.creator))) %>
-
- <% if @user_block.ends_at > Time.now.getutc %>
- <% if current_user and current_user.id == @user_block.creator_id %>
- - <%= link_to t(".edit"), edit_user_block_path(@user_block) %>
- <% end %>
- <% if can?(:revoke, UserBlock) %>
- - <%= link_to t(".revoke"), revoke_user_block_path(@user_block) %>
- <% end %>
- <% end %>
- - <%= link_to t(".back"), user_blocks_path %>
-
+
<% end %>
diff --git a/app/views/users/show.html.erb b/app/views/users/show.html.erb
index 0ea411811..1c5d3dc64 100644
--- a/app/views/users/show.html.erb
+++ b/app/views/users/show.html.erb
@@ -7,109 +7,113 @@
<%= @user.display_name %> <%= role_icons(@user) %>
<% if current_user and @user.id == current_user.id %>
-
- -
- <%= link_to t(".my edits"), :controller => "changesets", :action => "index", :display_name => current_user.display_name %>
- <%= number_with_delimiter(current_user.changesets.size) %>
-
- -
- <%= link_to t(".my notes"), user_notes_path(@user) %>
-
- -
- <%= link_to t(".my traces"), :controller => "traces", :action => "mine" %>
- <%= number_with_delimiter(current_user.traces.size) %>
-
- -
- <%= link_to t(".my diary"), :controller => "diary_entries", :action => "index", :display_name => current_user.display_name %>
- <%= number_with_delimiter(current_user.diary_entries.size) %>
-
- -
- <%= link_to t(".my comments"), diary_comments_path(current_user) %>
-
- -
- <%= link_to t(".my settings"), user_account_path(current_user) %>
-
-
- <% if current_user.blocks.exists? %>
+
+
<% else %>
-
+
+
<% end %>
@@ -130,37 +134,39 @@
<% if can?(:set_status, User) || can?(:destroy, User) %>
-
- <% if can? :set_status, User %>
- <% if ["active", "confirmed"].include? @user.status %>
- -
- <%= link_to t(".deactivate_user"), set_status_user_path(:status => "pending", :display_name => @user.display_name), :method => :post, :data => { :confirm => t(".confirm") } %>
-
- <% elsif ["pending"].include? @user.status %>
- -
- <%= link_to t(".activate_user"), set_status_user_path(:status => "active", :display_name => @user.display_name), :method => :post, :data => { :confirm => t(".confirm") } %>
-
- <% end %>
+
+
<% end %>
<% if current_user and current_user.administrator? -%>