From: Nenad Vujicic <nenadus@gmail.com>
Date: Wed, 19 Feb 2025 14:59:09 +0000 (+0100)
Subject: Improves behavior if note lacks opening comment
X-Git-Tag: live~203^2~3
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/33dd13457c9838ec97db8b1d69a2fb1f4578dd3b?ds=sidebyside

Improves behavior if note lacks opening comment

Adds checking if note lacks opening comment and if positive, returns nil for both note's author and description.
---

diff --git a/app/models/note.rb b/app/models/note.rb
index b7215d6f7..0a1f4abd7 100644
--- a/app/models/note.rb
+++ b/app/models/note.rb
@@ -95,7 +95,7 @@ class Note < ApplicationRecord
   # Return the note's description, derived from the first comment
   def description
     if user_ip.nil? && user_id.nil?
-      all_comments.first.body
+      all_comments.first.body if all_comments.first&.event == "opened"
     else
       RichText.new("text", super)
     end
@@ -104,7 +104,7 @@ class Note < ApplicationRecord
   # Return the note's author object, derived from the first comment
   def author
     if user_ip.nil? && user_id.nil?
-      all_comments.first.author
+      all_comments.first.author if all_comments.first&.event == "opened"
     else
       super
     end