From: Tom Hughes <tom@compton.nu>
Date: Mon, 30 Dec 2019 22:34:24 +0000 (+0000)
Subject: Merge remote-tracking branch 'upstream/pull/2444'
X-Git-Tag: live~3351
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/3426976606d30278fcf5ed279d3c95900785c4a5?hp=-c

Merge remote-tracking branch 'upstream/pull/2444'
---

3426976606d30278fcf5ed279d3c95900785c4a5
diff --combined app/controllers/site_controller.rb
index 3a69eed12,f57bb7c25..1fc916e7f
--- a/app/controllers/site_controller.rb
+++ b/app/controllers/site_controller.rb
@@@ -77,30 -77,26 +77,30 @@@ class SiteController < ApplicationContr
        )
      end
  
 -    if params[:node]
 -      bbox = Node.find(params[:node]).bbox.to_unscaled
 -      @lat = bbox.centre_lat
 -      @lon = bbox.centre_lon
 -      @zoom = 18
 -    elsif params[:way]
 -      bbox = Way.find(params[:way]).bbox.to_unscaled
 -      @lat = bbox.centre_lat
 -      @lon = bbox.centre_lon
 -      @zoom = 17
 -    elsif params[:note]
 -      note = Note.find(params[:note])
 -      @lat = note.lat
 -      @lon = note.lon
 -      @zoom = 17
 -    elsif params[:gpx] && current_user
 -      trace = Trace.visible_to(current_user).find(params[:gpx])
 -      @lat = trace.latitude
 -      @lon = trace.longitude
 -      @zoom = 16
 +    begin
 +      if params[:node]
 +        bbox = Node.visible.find(params[:node]).bbox.to_unscaled
 +        @lat = bbox.centre_lat
 +        @lon = bbox.centre_lon
 +        @zoom = 18
 +      elsif params[:way]
 +        bbox = Way.visible.find(params[:way]).bbox.to_unscaled
 +        @lat = bbox.centre_lat
 +        @lon = bbox.centre_lon
 +        @zoom = 17
 +      elsif params[:note]
 +        note = Note.visible.find(params[:note])
 +        @lat = note.lat
 +        @lon = note.lon
 +        @zoom = 17
 +      elsif params[:gpx] && current_user
 +        trace = Trace.visible_to(current_user).find(params[:gpx])
 +        @lat = trace.latitude
 +        @lon = trace.longitude
 +        @zoom = 16
 +      end
 +    rescue ActiveRecord::RecordNotFound
 +      # don't try and derive a location from a missing/deleted object
      end
    end
  
@@@ -112,7 -108,9 +112,9 @@@
  
    def help; end
  
-   def about; end
+   def about
+     @locale = params[:about_locale] || I18n.locale
+   end
  
    def export; end
  
diff --combined config/routes.rb
index 992197814,6764335d6..37ffa2d9a
--- a/config/routes.rb
+++ b/config/routes.rb
@@@ -12,6 -12,7 +12,6 @@@ OpenStreetMap::Application.routes.draw 
      put "changeset/create" => "api/changesets#create"
      post "changeset/:id/upload" => "api/changesets#upload", :id => /\d+/
      get "changeset/:id/download" => "api/changesets#download", :as => :changeset_download, :id => /\d+/
 -    post "changeset/:id/expand_bbox" => "api/changesets#expand_bbox", :id => /\d+/
      get "changeset/:id" => "api/changesets#show", :as => :changeset_show, :id => /\d+/
      post "changeset/:id/subscribe" => "api/changesets#subscribe", :as => :changeset_subscribe, :id => /\d+/
      post "changeset/:id/unsubscribe" => "api/changesets#unsubscribe", :as => :changeset_unsubscribe, :id => /\d+/
@@@ -145,6 -146,7 +145,7 @@@
    get "/welcome" => "site#welcome"
    get "/fixthemap" => "site#fixthemap"
    get "/help" => "site#help"
+   get "/about/:about_locale" => "site#about"
    get "/about" => "site#about"
    get "/history" => "changesets#index"
    get "/history/feed" => "changesets#feed", :defaults => { :format => :atom }
@@@ -207,6 -209,7 +208,6 @@@
    get "/trace/create", :to => redirect(:path => "/traces/new")
    get "/trace/:id/data" => "traces#data", :id => /\d+/, :as => "trace_data"
    get "/trace/:id/edit", :to => redirect(:path => "/traces/%{id}/edit")
 -  post "/trace/:id/delete" => "traces#delete", :id => /\d+/
  
    # diary pages
    resources :diary_entries, :path => "diary", :only => [:new, :create, :index] do