From: Andy Allan <git@gravitystorm.co.uk>
Date: Wed, 28 Jul 2021 15:36:13 +0000 (+0100)
Subject: Fix redirect to terms path when not logged in
X-Git-Tag: live~2396^2
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/36f6d8d85d9549d7652a425600a54cae7be04b4d?ds=inline;hp=-c

Fix redirect to terms path when not logged in

This was missed during #3147 since it wasn't covered by a test.
---

36f6d8d85d9549d7652a425600a54cae7be04b4d
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb
index ec30eb4e7..727d8ee3f 100644
--- a/app/controllers/users_controller.rb
+++ b/app/controllers/users_controller.rb
@@ -30,7 +30,7 @@ class UsersController < ApplicationController
         # Already agreed to terms, so just show settings
         redirect_to :action => :account, :display_name => current_user.display_name
       elsif current_user.nil? && session[:new_user].nil?
-        redirect_to :action => :login, :referer => request.fullpath
+        redirect_to login_path(:referer => request.fullpath)
       end
     end
   end
diff --git a/test/controllers/users_controller_test.rb b/test/controllers/users_controller_test.rb
index a73e48211..10c5c3bee 100644
--- a/test/controllers/users_controller_test.rb
+++ b/test/controllers/users_controller_test.rb
@@ -414,6 +414,12 @@ class UsersControllerTest < ActionDispatch::IntegrationTest
     assert_redirected_to :action => :terms, :referer => "/user/#{ERB::Util.u(user.display_name)}/account"
   end
 
+  def test_terms_not_logged_in
+    get user_terms_path
+
+    assert_redirected_to login_path(:referer => "/user/terms")
+  end
+
   def test_go_public
     user = create(:user, :data_public => false)
     session_for(user)