From: Anton Khorev <tony29@yandex.ru>
Date: Wed, 10 Jul 2024 10:16:15 +0000 (+0300)
Subject: Remove single-use OpenID logo helper
X-Git-Tag: live~389^2~1
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/38bfb33c02d7e2611b7398d43e113dd1ef64fecd

Remove single-use OpenID logo helper
---

diff --git a/app/helpers/user_helper.rb b/app/helpers/user_helper.rb
index 26ba2c528..734a266db 100644
--- a/app/helpers/user_helper.rb
+++ b/app/helpers/user_helper.rb
@@ -52,10 +52,6 @@ module UserHelper
 
   # External authentication support
 
-  def openid_logo
-    image_tag "openid.svg", :size => "36", :alt => t("application.auth_providers.openid_logo_alt"), :class => "align-text-bottom"
-  end
-
   def auth_button(name, provider, options = {})
     link_to(
       image_tag("#{name}.svg",
diff --git a/app/views/application/_auth_providers.html.erb b/app/views/application/_auth_providers.html.erb
index 14e296a07..4b487cc5d 100644
--- a/app/views/application/_auth_providers.html.erb
+++ b/app/views/application/_auth_providers.html.erb
@@ -47,7 +47,7 @@
   <%= form_tag(auth_path(:provider => "openid"), :id => "openid_login_form") do %>
     <div id="login_openid_url" class="mb-3">
       <label for="openid_url" class="form-label">
-        <%= openid_logo %>
+        <%= image_tag "openid.svg", :size => "36", :alt => t(".openid_logo_alt"), :class => "align-text-bottom" %>
         <%= t ".openid_url" %>
       </label>
       <%= hidden_field_tag("referer", params[:referer], :autocomplete => "off") %>
diff --git a/test/helpers/user_helper_test.rb b/test/helpers/user_helper_test.rb
index eaf406a06..53b9a823b 100644
--- a/test/helpers/user_helper_test.rb
+++ b/test/helpers/user_helper_test.rb
@@ -109,11 +109,6 @@ class UserHelperTest < ActionView::TestCase
     assert_match %r{^<img .* width="50" height="50" .* />$}, thumbnail
   end
 
-  def test_openid_logo
-    logo = openid_logo
-    assert_match %r{^<img .* src="/images/openid.svg" .* />$}, logo
-  end
-
   def test_auth_button
     button = auth_button("google", "google")
     img_tag = "<img alt=\"Google logo\" class=\"rounded-1\" src=\"/images/google.svg\" width=\"36\" height=\"36\" />"