From: mmd-osm <mmd.osm@gmail.com>
Date: Sun, 1 Sep 2024 19:39:05 +0000 (+0200)
Subject: I18n: messages: avoid dynamic translation keys
X-Git-Tag: live~197^2
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/3d3e143811ff5e476c8711c4669fe4322901aa50

I18n: messages: avoid dynamic translation keys

By moving the translation outside the loop and calling t(...) with
explicitly stated keys, `bundle exec i18n-tasks unused` no longer
reports the keys as unused.
---

diff --git a/app/views/messages/_heading.html.erb b/app/views/messages/_heading.html.erb
index 90995ed88..c3b479202 100644
--- a/app/views/messages/_heading.html.erb
+++ b/app/views/messages/_heading.html.erb
@@ -3,14 +3,14 @@
 <% content_for :heading do %>
   <h1><%= t("users.show.my messages") %></h1>
   <ul class="nav nav-tabs">
-    <% { ".my_inbox" => inbox_messages_path, ".my_outbox" => outbox_messages_path, ".muted_messages" => muted_messages_path }.each do |i18n_key, path| %>
+    <% { t(".my_inbox") => inbox_messages_path, t(".my_outbox") => outbox_messages_path, t(".muted_messages") => muted_messages_path }.each do |label, path| %>
     <% next if path == muted_messages_path && current_user.muted_messages.none? %>
 
     <li class="nav-item">
       <% if path == active_link_path %>
-        <a class="nav-link active"><%= t(i18n_key) %></a>
+        <a class="nav-link active"><%= label %></a>
       <% else %>
-        <%= link_to t(i18n_key), path, :class => "nav-link" %>
+        <%= link_to label, path, :class => "nav-link" %>
       <% end %>
     </li>
     <% end %>