From: Tom Hughes <tom@compton.nu>
Date: Tue, 16 Aug 2016 18:27:14 +0000 (+0100)
Subject: Fix rubocop warnings
X-Git-Tag: live~4396
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/47e6637f180c9ffa3950ee9307f9667ffcfc2ee3

Fix rubocop warnings
---

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 1b63d25f2..927f40780 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -74,7 +74,7 @@ Metrics/MethodLength:
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 131
+  Max: 139
 
 # Offense count: 4
 # Configuration parameters: CountKeywordArgs.
diff --git a/app/helpers/browse_helper.rb b/app/helpers/browse_helper.rb
index 8a0721c58..76a6d5eb1 100644
--- a/app/helpers/browse_helper.rb
+++ b/app/helpers/browse_helper.rb
@@ -72,9 +72,10 @@ module BrowseHelper
     elsif wdt = wikidata_links(key, value)
       # IMPORTANT: Note that wikidata_links() returns an array of hashes, unlike for example wikipedia_link(),
       # which just returns one such hash.
-      wdt.map do |w|
+      wdt = wdt.map do |w|
         link_to(w[:title], w[:url], :title => t("browse.tag_details.wikidata_link", :page => w[:title].strip))
-      end.join(";").html_safe
+      end
+      safe_join(wdt, ";")
     elsif url = wiki_link("tag", "#{key}=#{value}")
       link_to h(value), url, :title => t("browse.tag_details.wiki_link.tag", :key => key, :value => value)
     elsif url = telephone_link(key, value)