From: Tom Hughes <tom@compton.nu>
Date: Tue, 16 May 2023 17:44:14 +0000 (+0100)
Subject: Add rubocop-factory_bot and fix warnings
X-Git-Tag: live~1270
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/52296d1cadfe9c725f101c6ec8a1463873c54d88

Add rubocop-factory_bot and fix warnings
---

diff --git a/.rubocop.yml b/.rubocop.yml
index cfa31cc04..051b7a6a7 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -2,6 +2,7 @@ inherit_from: .rubocop_todo.yml
 
 require:
   - rubocop-capybara
+  - rubocop-factory_bot
   - rubocop-minitest
   - rubocop-performance
   - rubocop-rails
diff --git a/Gemfile b/Gemfile
index c25240f9f..39ffed860 100644
--- a/Gemfile
+++ b/Gemfile
@@ -153,6 +153,7 @@ group :test do
   gem "rails-controller-testing"
   gem "rubocop"
   gem "rubocop-capybara"
+  gem "rubocop-factory_bot"
   gem "rubocop-minitest"
   gem "rubocop-performance"
   gem "rubocop-rails"
diff --git a/Gemfile.lock b/Gemfile.lock
index 4c0b25147..0927586ab 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -444,6 +444,8 @@ GEM
       parser (>= 3.2.1.0)
     rubocop-capybara (2.18.0)
       rubocop (~> 1.41)
+    rubocop-factory_bot (2.23.1)
+      rubocop (~> 1.33)
     rubocop-minitest (0.31.0)
       rubocop (>= 1.39, < 2.0)
     rubocop-performance (1.17.1)
@@ -603,6 +605,7 @@ DEPENDENCIES
   rotp
   rubocop
   rubocop-capybara
+  rubocop-factory_bot
   rubocop-minitest
   rubocop-performance
   rubocop-rails
diff --git a/test/controllers/browse_controller_test.rb b/test/controllers/browse_controller_test.rb
index 578e78fa2..674a318ed 100644
--- a/test/controllers/browse_controller_test.rb
+++ b/test/controllers/browse_controller_test.rb
@@ -55,13 +55,13 @@ class BrowseControllerTest < ActionDispatch::IntegrationTest
   end
 
   def test_read_node
-    node = create :node
+    node = create(:node)
     browse_check :node_path, node.id, "browse/feature"
     assert_select "a[href='#{api_node_path node}']", :count => 1
   end
 
   def test_read_deleted_node
-    node = create :node, :visible => false
+    node = create(:node, :visible => false)
     browse_check :node_path, node.id, "browse/feature"
     assert_select "a[href='#{api_node_path node}']", :count => 0
   end