From: Anton Khorev <tony29@yandex.ru>
Date: Sat, 1 Feb 2025 17:09:38 +0000 (+0300)
Subject: Remove ids collected in parallel to model instances in map api
X-Git-Tag: live~166^2~1
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/560146d88c0c8a49d723d63ce79a382b90431133

Remove ids collected in parallel to model instances in map api
---

diff --git a/app/controllers/api/maps_controller.rb b/app/controllers/api/maps_controller.rb
index 2aa25fdd7..c37ba2a3e 100644
--- a/app/controllers/api/maps_controller.rb
+++ b/app/controllers/api/maps_controller.rb
@@ -57,26 +57,18 @@ module Api
 
       nodes += Node.includes(:node_tags).find(nodes_to_fetch) unless nodes_to_fetch.empty?
 
-      visible_nodes = {}
       @nodes = []
       nodes.each do |node|
-        if node.visible?
-          visible_nodes[node.id] = node
-          @nodes << node
-        end
+        @nodes << node if node.visible?
       end
 
       @ways = []
-      way_ids = []
       ways.each do |way|
-        if way.visible?
-          way_ids << way.id
-          @ways << way
-        end
+        @ways << way if way.visible?
       end
 
-      @relations = Relation.nodes(visible_nodes.keys).visible +
-                   Relation.ways(way_ids).visible
+      @relations = Relation.nodes(@nodes).visible +
+                   Relation.ways(@ways).visible
 
       # we do not normally return the "other" partners referenced by an relation,
       # e.g. if we return a way A that is referenced by relation X, and there's