From: Tom Hughes <tom@compton.nu>
Date: Wed, 23 May 2018 11:09:21 +0000 (+0100)
Subject: Completely remove form-action restrictions for OAuth callbacks
X-Git-Tag: live~3537
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/5deba2782a57a8d84024c941bf0a31b7c0b64c49?ds=sidebyside

Completely remove form-action restrictions for OAuth callbacks

The CSP3 draft only allows a * rule match network schemes and
mobile devices often use callbacks to custom URL schemes.
---

diff --git a/app/controllers/oauth_controller.rb b/app/controllers/oauth_controller.rb
index ae6d0983b..801d88a18 100644
--- a/app/controllers/oauth_controller.rb
+++ b/app/controllers/oauth_controller.rb
@@ -38,7 +38,7 @@ class OauthController < ApplicationController
   protected
 
   def oauth1_authorize
-    append_content_security_policy_directives(:form_action => %w[*])
+    override_content_security_policy_directives(:form_action => false)
 
     if @token.invalidated?
       @message = t "oauth.authorize_failure.invalid"