From: ENT8R <info.ent8r@gmail.com>
Date: Sun, 26 Aug 2018 17:06:01 +0000 (+0200)
Subject: Add some more tests
X-Git-Tag: live~3366^2~6
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/5f1f8f3c919fe1752ef1c4cbd846705525e57101?hp=98402908b0d87b66bc3cac9d5a68782f3d966bc8

Add some more tests
---

diff --git a/test/controllers/notes_controller_test.rb b/test/controllers/notes_controller_test.rb
index e4401d6e9..837b066a2 100644
--- a/test/controllers/notes_controller_test.rb
+++ b/test/controllers/notes_controller_test.rb
@@ -876,6 +876,45 @@ class NotesControllerTest < ActionController::TestCase
     end
   end
 
+  def test_search_by_user_success
+    user = create(:user)
+
+    create(:note) do |note|
+      create(:note_comment, :note => note, :author => user)
+    end
+
+    get :search, :params => { :display_name => user.display_name, :format => "xml" }
+    assert_response :success
+    assert_equal "application/xml", @response.content_type
+    assert_select "osm", :count => 1 do
+      assert_select "note", :count => 1
+    end
+
+    get :search, :params => { :display_name => user.display_name, :format => "json" }
+    assert_response :success
+    assert_equal "application/json", @response.content_type
+    js = ActiveSupport::JSON.decode(@response.body)
+    assert_not_nil js
+    assert_equal "FeatureCollection", js["type"]
+    assert_equal 1, js["features"].count
+
+    get :search, :params => { :display_name => user.display_name, :format => "rss" }
+    assert_response :success
+    assert_equal "application/rss+xml", @response.content_type
+    assert_select "rss", :count => 1 do
+      assert_select "channel", :count => 1 do
+        assert_select "item", :count => 1
+      end
+    end
+
+    get :search, :params => { :display_name => user.display_name, :format => "gpx" }
+    assert_response :success
+    assert_equal "application/gpx+xml", @response.content_type
+    assert_select "gpx", :count => 1 do
+      assert_select "wpt", :count => 1
+    end
+  end
+
   def test_search_no_match
     create(:note_with_comments)
 
@@ -917,6 +956,18 @@ class NotesControllerTest < ActionController::TestCase
 
     get :search, :params => { :q => "no match", :limit => "10001", :format => "json" }
     assert_response :bad_request
+
+    get :search, :params => { :display_name => "non-existent" }
+    assert_response :bad_request
+
+    get :search, :params => { :id => "-1" }
+    assert_response :bad_request
+
+    get :search, :params => { :from => "wrong-date", :to => "wrong-date" }
+    assert_response :bad_request
+
+    get :search, :params => { :from => "2018.08.2018", :to => "2018.09.2018" }
+    assert_response :bad_request
   end
 
   def test_feed_success