From: John Firebaugh <john.firebaugh@gmail.com>
Date: Wed, 10 Jul 2013 22:17:42 +0000 (-0700)
Subject: Switch back to links for sharing
X-Git-Tag: live~5463^2~10
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/68a46f24522786b535809b0846d0bb6502c97406?hp=dc8751cf7af7ce0e0033c078dac064d62ab819e6

Switch back to links for sharing
---

diff --git a/app/assets/javascripts/leaflet.share.js b/app/assets/javascripts/leaflet.share.js
index e34d5ffdb..f261a9d72 100644
--- a/app/assets/javascripts/leaflet.share.js
+++ b/app/assets/javascripts/leaflet.share.js
@@ -29,39 +29,24 @@ L.OSM.share = function (options) {
         $('<h4>')
           .text(I18n.t('javascripts.share.title')));
 
-    var $share_link = $('<section>')
+    var $linkSection = $('<section>')
+      .attr('class', 'share-link')
       .appendTo($ui);
 
-    var $title = $('<h4>')
+    $('<h4>')
       .text(I18n.t('javascripts.share.link'))
-      .appendTo($share_link);
+      .appendTo($linkSection);
 
-    var $input = $('<input />')
-      .attr('type', 'text')
-      .on('click', select)
-      .appendTo($share_link);
+    var $shortLink, $longLink;
 
-    var $list = $('<ul>')
-      .appendTo($share_link);
-
-    var $short_option = $('<li>')
-      .appendTo($list);
-
-    var $short_url_label = $('<label></label>')
-      .attr('for', 'short_url')
-      .appendTo($short_option);
-
-    var $short_url_input = $('<input />')
-      .attr('id', 'short_url')
-      .attr('type', 'checkbox')
-      .prop('checked', 'checked')
-      .appendTo($short_url_label)
-      .bind('change', function() {
-          options.short = $(this).prop('checked');
-          update();
-      });
-
-    $short_url_label.append(I18n.t('javascripts.share.short_url'));
+    $('<ul>')
+      .appendTo($linkSection)
+      .append($('<li>')
+        .append($longLink = $('<a>')
+          .text(I18n.t('javascripts.share.long_link'))))
+      .append($('<li>')
+        .append($shortLink = $('<a>')
+          .text(I18n.t('javascripts.share.short_link'))));
 
     map.on('moveend layeradd layerremove', update);
 
@@ -71,13 +56,12 @@ L.OSM.share = function (options) {
       e.stopPropagation();
       e.preventDefault();
       options.sidebar.togglePane($ui);
-      $input.select();
+      update();
     }
 
     function update() {
-      $input.val(
-          options.short ? options.getShortUrl(map) : options.getUrl(map)
-      );
+      $shortLink.attr('href', options.getShortUrl(map));
+      $longLink.attr('href', options.getUrl(map));
     }
 
     function select() {
diff --git a/app/assets/stylesheets/common.css.scss b/app/assets/stylesheets/common.css.scss
index 4afc71533..615bdeedc 100644
--- a/app/assets/stylesheets/common.css.scss
+++ b/app/assets/stylesheets/common.css.scss
@@ -624,6 +624,15 @@ a.donate {
   }
 }
 
+.share-ui {
+  .share-link {
+    li {
+      display: inline-block;
+      width: 50%;
+    }
+  }
+}
+
 .site-index .leaflet-top,
 .site-export .leaflet-top {
   top: $lineheight/2 !important;
diff --git a/config/locales/en.yml b/config/locales/en.yml
index 3daf2504d..e542006d7 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -2042,7 +2042,8 @@ en:
       title: "Share"
       cancel: "Cancel"
       link: "Link"
-      short_url: "Short URL"
+      short_link: "Short Link"
+      long_link: "Long Link"
     key:
       title: "Map Key"
       tooltip: "Map Key"