From: Andy Allan <git@gravitystorm.co.uk>
Date: Wed, 7 Sep 2016 10:02:20 +0000 (+0100)
Subject: Use .present? instead of double negative to check if terms_agreed timestamp is set.
X-Git-Tag: live~4761
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/6cc4f4506b9a6612f57dd33d79e933d181a02713

Use .present? instead of double negative to check if terms_agreed timestamp is set.
---

diff --git a/app/views/user/api_read.builder b/app/views/user/api_read.builder
index 2b304f53c..55775df9e 100644
--- a/app/views/user/api_read.builder
+++ b/app/views/user/api_read.builder
@@ -7,10 +7,10 @@ xml.osm("version" => API_VERSION, "generator" => GENERATOR) do
       xml.tag! "description", @this_user.description
     end
     if @user && @user == @this_user
-      xml.tag! "contributor-terms", :agreed => !!@this_user.terms_agreed,
+      xml.tag! "contributor-terms", :agreed => @this_user.terms_agreed.present?,
                                     :pd => @this_user.consider_pd
     else
-      xml.tag! "contributor-terms", :agreed => !!@this_user.terms_agreed
+      xml.tag! "contributor-terms", :agreed => @this_user.terms_agreed.present?
     end
     if @this_user.image.file? or @this_user.image_use_gravatar
       xml.tag! "img", :href => user_image_url(@this_user, :size => 256)