From: Tom Hughes <tom@compton.nu>
Date: Sun, 18 Aug 2024 10:59:42 +0000 (+0100)
Subject: Merge remote-tracking branch 'upstream/pull/5091'
X-Git-Tag: live~688
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/71d459c71c63ebebdadea3593848eda52a30ce6c?hp=-c

Merge remote-tracking branch 'upstream/pull/5091'
---

71d459c71c63ebebdadea3593848eda52a30ce6c
diff --combined test/controllers/user_blocks_controller_test.rb
index 57481abf8,277926fdc..e6782a64d
--- a/test/controllers/user_blocks_controller_test.rb
+++ b/test/controllers/user_blocks_controller_test.rb
@@@ -13,10 -13,6 +13,6 @@@ class UserBlocksControllerTest < Action
        { :path => "/user_blocks", :method => :get },
        { :controller => "user_blocks", :action => "index" }
      )
-     assert_routing(
-       { :path => "/user_blocks/new", :method => :get },
-       { :controller => "user_blocks", :action => "new" }
-     )
      assert_routing(
        { :path => "/user_blocks", :method => :post },
        { :controller => "user_blocks", :action => "create" }
@@@ -799,8 -795,6 +795,8 @@@
    end
  
    def check_inactive_block_updates(block)
 +    original_ends_at = block.ends_at
 +
      put user_block_path(block,
                          :user_block_period => "0",
                          :user_block => { :needs_view => false, :reason => "Updated Reason" })
@@@ -809,7 -803,6 +805,7 @@@
      block.reload
      assert_not_predicate block, :active?
      assert_equal "Updated Reason", block.reason
 +    assert_equal original_ends_at, block.ends_at
  
      put user_block_path(block,
                          :user_block_period => "0",
@@@ -819,7 -812,6 +815,7 @@@
      block.reload
      assert_not_predicate block, :active?
      assert_equal "Updated Reason", block.reason
 +    assert_equal original_ends_at, block.ends_at
  
      put user_block_path(block,
                          :user_block_period => "1",
@@@ -829,7 -821,6 +825,7 @@@
      block.reload
      assert_not_predicate block, :active?
      assert_equal "Updated Reason", block.reason
 +    assert_equal original_ends_at, block.ends_at
  
      put user_block_path(block,
                          :user_block_period => "0",
@@@ -839,7 -830,6 +835,7 @@@
      block.reload
      assert_not_predicate block, :active?
      assert_equal "Updated Reason Again", block.reason
 +    assert_equal original_ends_at, block.ends_at
    end
  
    def check_user_blocks_table(user_blocks)