From: Tom Hughes Date: Wed, 22 Feb 2023 18:17:51 +0000 (+0000) Subject: Merge remote-tracking branch 'upstream/pull/3936' X-Git-Tag: live~1289 X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/721d33033cbd729ab9e2d0220ead22fb3f7f1065?hp=ab4de87d1eef4546a96738154cf81b7d7f72d988 Merge remote-tracking branch 'upstream/pull/3936' --- diff --git a/app/views/accounts/_go_public.html.erb b/app/views/accounts/_go_public.html.erb new file mode 100644 index 000000000..af3667e65 --- /dev/null +++ b/app/views/accounts/_go_public.html.erb @@ -0,0 +1,14 @@ +
+ +

<%= t ".heading" %>

+

+ <%= t ".currently_not_public" %> + <%= t ".only_public_can_edit" %> + <%= t ".find_out_why_html", :link => link_to(t(".find_out_why"), + t(".find_out_why_url")) %> +

+ +<%= button_to t(".make_edits_public_button"), user_go_public_path, :class => "btn btn-primary" %> diff --git a/app/views/accounts/edit.html.erb b/app/views/accounts/edit.html.erb index 7aad944d3..e783367dd 100644 --- a/app/views/accounts/edit.html.erb +++ b/app/views/accounts/edit.html.erb @@ -65,8 +65,5 @@ <% end %> <% unless current_user.data_public? %> - -

<%= t ".public editing note.heading" %>

-<%= t ".public editing note.html" %> -<%= button_to t(".make edits public button"), user_go_public_path, :class => "btn btn-primary" %> + <%= render :partial => "go_public" %> <% end %> diff --git a/app/views/site/_any_questions.html.erb b/app/views/site/_any_questions.html.erb new file mode 100644 index 000000000..b330d8035 --- /dev/null +++ b/app/views/site/_any_questions.html.erb @@ -0,0 +1,4 @@ +

<%= t ".title" %>

+ +

<%= t ".paragraph_1_html", :help_link => link_to(t(".get_help_here"), help_path), + :welcome_mat_link => link_to(t(".welcome_mat"), t(".welcome_mat_url")) %>

diff --git a/app/views/site/export.html.erb b/app/views/site/export.html.erb index 6dd54f315..a314cb151 100644 --- a/app/views/site/export.html.erb +++ b/app/views/site/export.html.erb @@ -18,7 +18,7 @@

<%= t ".licence" %>

-

<%= t ".export_details_html" %>

+

<%= t ".licence_details_html", :odbl_link => link_to(t(".odbl"), t(".odbl_url")) %>

diff --git a/app/views/site/fixthemap.html.erb b/app/views/site/fixthemap.html.erb index 70118b980..fe6cf22c5 100644 --- a/app/views/site/fixthemap.html.erb +++ b/app/views/site/fixthemap.html.erb @@ -21,7 +21,7 @@

<%= t "site.welcome.add_a_note.title" %>
-

<%= t "site.welcome.add_a_note.paragraph_1_html" %>

+

<%= t "site.welcome.add_a_note.para_1" %>

<%= t ".how_to_help.add_a_note.instructions_html", :map_url => root_path %>

@@ -29,6 +29,4 @@

<%= t ".other_concerns.title" %>

<%= t ".other_concerns.explanation_html" %>

-

<%= t "site.welcome.questions.title" %>

- -

<%= t "site.welcome.questions.paragraph_1_html", :help_url => help_path %>

+<%= render "any_questions" %> diff --git a/app/views/site/welcome.html.erb b/app/views/site/welcome.html.erb index 7c1ee38ab..b05620f59 100644 --- a/app/views/site/welcome.html.erb +++ b/app/views/site/welcome.html.erb @@ -6,7 +6,7 @@

<%= t ".title" %>

<% end %> -

<%= t ".introduction_html" %>

+

<%= t ".introduction" %>

<%= t ".whats_on_the_map.title" %>

@@ -15,49 +15,48 @@
-

<%= t ".whats_on_the_map.on_html" %>

+

<%= t ".whats_on_the_map.on_the_map_html", :real_and_current => tag.em(t(".whats_on_the_map.real_and_current")) %>

-

<%= t ".whats_on_the_map.off_html" %>

+

<%= t ".whats_on_the_map.off_the_map_html", :doesnt => tag.em(t(".whats_on_the_map.doesnt")) %>

<%= t ".basic_terms.title" %>

-

<%= t ".basic_terms.paragraph_1_html" %>

+

<%= t ".basic_terms.paragraph_1" %>

-

<%= t ".basic_terms.editor_html" %>

+

<%= t ".basic_terms.an_editor_html", :editor => tag.strong(t(".basic_terms.editor")) %>

-

<%= t ".basic_terms.node_html" %>

+

<%= t ".basic_terms.a_node_html", :node => tag.strong(t(".basic_terms.node")) %>

-

<%= t ".basic_terms.way_html" %>

+

<%= t ".basic_terms.a_way_html", :way => tag.strong(t(".basic_terms.way")) %>

-

<%= t ".basic_terms.tag_html" %>

+

<%= t ".basic_terms.a_tag_html", :tag => tag.strong(t(".basic_terms.tag")) %>

<%= t ".rules.title" %>

-

<%= t ".rules.paragraph_1_html" %>

+

<%= t ".rules.para_1_html", :imports_link => link_to(t(".rules.imports"), t(".rules.imports_url")), + :automated_edits_link => link_to(t(".rules.automated_edits"), t(".rules.automated_edits_url")) %>

-

<%= t ".questions.title" %>

- -

<%= t ".questions.paragraph_1_html", :help_url => help_path %>

+ <%= render "any_questions" %>
@@ -66,6 +65,7 @@

<%= t ".add_a_note.title" %>

-

<%= t ".add_a_note.paragraph_1_html" %>

-

<%= t ".add_a_note.paragraph_2_html", :map_url => root_path %>

+

<%= t ".add_a_note.para_1" %>

+

<%= t ".add_a_note.para_2_html", :map_link => link_to(t(".add_a_note.the_map"), root_path), + :note_icon => tag.span(:class => "icon note") %>

diff --git a/app/views/traces/index.html.erb b/app/views/traces/index.html.erb index b930491c6..71b25afe0 100644 --- a/app/views/traces/index.html.erb +++ b/app/views/traces/index.html.erb @@ -76,5 +76,7 @@ <%= render "trace_paging_nav", :page => @page, :page_size => @page_size, :traces => @traces, :params => @params %> <% else %> -

<%= t ".empty_html", :upload_link => new_trace_path %>

+

<%= t ".empty_title" %>

+

<%= t ".empty_upload_html", :upload_link => link_to(t(".upload_new"), new_trace_path), + :wiki_link => link_to(t(".wiki_page"), t(".wiki_page_url")) %>

<% end %> diff --git a/app/views/users/new.html.erb b/app/views/users/new.html.erb index 262cd4a06..f160de913 100644 --- a/app/views/users/new.html.erb +++ b/app/views/users/new.html.erb @@ -13,7 +13,8 @@

<%= t ".about.header" %>

- <%= t ".about.html" %> +

<%= t ".about.paragraph_1" %>

+

<%= t ".about.paragraph_2" %>

diff --git a/config/locales/en.yml b/config/locales/en.yml index 853a20f22..fc01c22ae 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -273,9 +273,6 @@ en: enabled link text: "what is this?" disabled: "Disabled and cannot edit data, all previous edits are anonymous." disabled link text: "why can't I edit?" - public editing note: - heading: "Public editing" - html: "Currently your edits are anonymous and people cannot send you messages or see your location. To show what you edited and allow people to contact you through the website, click the button below. Since the 0.6 API changeover, only public users can edit map data. (find out why).
  • Your email address will not be revealed by becoming public.
  • This action cannot be reversed and all new users are now public by default.
" contributor terms: heading: "Contributor Terms" agreed: "You have agreed to the new Contributor Terms." @@ -285,8 +282,17 @@ en: link: "https://wiki.osmfoundation.org/wiki/Licence/Contributor_Terms" link text: "what is this?" save changes button: Save Changes - make edits public button: Make all my edits public delete_account: Delete Account... + go_public: + heading: "Public editing" + currently_not_public: "Currently your edits are anonymous and people cannot send you messages or see your location. To show what you edited and allow people to contact you through the website, click the button below." + only_public_can_edit: Since the 0.6 API changeover, only public users can edit map data. + find_out_why_html: (%{link}). + find_out_why: "find out why" + find_out_why_url: https://wiki.openstreetmap.org/wiki/Anonymous_edits + email_not_revealed: Your email address will not be revealed by becoming public. + not_reversible: This action cannot be reversed and all new users are now public by default. + make_edits_public_button: Make all my edits public update: success_confirm_needed: "User information updated successfully. Check your email for a note to confirm your new email address." success: "User information updated successfully." @@ -2052,7 +2058,9 @@ en: map_image: "Map Image (shows standard layer)" embeddable_html: "Embeddable HTML" licence: "Licence" - export_details_html: 'OpenStreetMap data is licensed under the Open Data Commons Open Database License (ODbL).' + licence_details_html: OpenStreetMap data is licensed under the %{odbl_link} (ODbL). + odbl: Open Data Commons Open Database License + odbl_url: https://opendatacommons.org/licenses/odbl/1.0/ too_large: advice: "If the above export fails, please consider using one of the sources listed below:" body: "This area is too large to be exported as OpenStreetMap XML Data. Please zoom in or select a smaller area, or use one of the sources listed below for bulk data downloads." @@ -2152,6 +2160,15 @@ en: removed: Your default OpenStreetMap editor is set as Potlatch. Because Adobe Flash Player has been withdrawn, Potlatch is no longer available to use in a web browser. desktop_html: You can still use Potlatch by downloading the desktop application for Mac and Windows. id_html: Alternatively, you can set your default editor to iD, which runs in your web browser as Potlatch formerly did. Change your preferences here. + any_questions: + title: Any questions? + paragraph_1_html: | + OpenStreetMap has several resources for learning about the project, asking and answering + questions, and collaboratively discussing and documenting mapping topics. + %{help_link}. With an organization making plans for OpenStreetMap? %{welcome_mat_link}. + get_help_here: Get help here + welcome_mat: Check out the Welcome Mat + welcome_mat_url: https://welcome.openstreetmap.org/ sidebar: search_results: Search Results close: Close @@ -2238,57 +2255,56 @@ en: toilets: "Toilets" welcome: title: Welcome! - introduction_html: | + introduction: | Welcome to OpenStreetMap, the free and editable map of the world. Now that you're signed up, you're all set to get started mapping. Here's a quick guide with the most important things you need to know. whats_on_the_map: title: What's on the Map - on_html: | - OpenStreetMap is a place for mapping things that are both real and current - + on_the_map_html: | + OpenStreetMap is a place for mapping things that are both %{real_and_current} - it includes millions of buildings, roads, and other details about places. You can map whatever real-world features are interesting to you. - off_html: | - What it doesn't include is opinionated data like ratings, historical or + real_and_current: real and current + off_the_map_html: | + What it %{doesnt} include is opinionated data like ratings, historical or hypothetical features, and data from copyrighted sources. Unless you have special permission, don't copy from online or paper maps. + doesnt: doesn't basic_terms: title: Basic Terms For Mapping - paragraph_1_html: | + paragraph_1: | OpenStreetMap has some of its own lingo. Here are a few key words that'll come in handy. - editor_html: | - An editor is a program or website you can use to edit the map. - node_html: | - A node is a point on the map, like a single restaurant or a tree. - way_html: | - A way is a line or area, like a road, stream, lake or building. - tag_html: | - A tag is a bit of data about a node or way, like a - restaurant's name or a road's speed limit. + an_editor_html: An %{editor} is a program or website you can use to edit the map. + a_node_html: A %{node} is a point on the map, like a single restaurant or a tree. + a_way_html: A %{way} is a line or area, like a road, stream, lake or building. + a_tag_html: A %{tag} is a bit of data about a node or way, like a restaurant's name or a road's speed limit. + editor: editor + node: node + way: way + tag: tag rules: title: Rules! - paragraph_1_html: | + para_1_html: | OpenStreetMap has few formal rules but we expect all participants to collaborate with, and communicate with, the community. If you are considering any activities other than editing by hand, please read and follow the guidelines on - Imports and - Automated Edits. - questions: - title: Any questions? - paragraph_1_html: | - OpenStreetMap has several resources for learning about the project, asking and answering - questions, and collaboratively discussing and documenting mapping topics. - Get help here. With an organization making plans for OpenStreetMap? Check out the Welcome Mat. + %{imports_link} and %{automated_edits_link}. + imports: Imports + imports_url: https://wiki.openstreetmap.org/wiki/Import/Guidelines + automated_edits: Automated Edits + automated_edits_url: https://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct start_mapping: Start Mapping add_a_note: title: No Time To Edit? Add a Note! - paragraph_1_html: | + para_1: | If you just want something small fixed and don't have the time to sign up and learn how to edit, it's easy to add a note. - paragraph_2_html: | - Just go to the map and click the note icon: - . This will add a marker to the map, which you can move - by dragging. Add your message, then click save, and other mappers will investigate. + para_2_html: | + Just go to %{map_link} and click the note icon: %{note_icon}. + This will add a marker to the map, which you can move by dragging. + Add your message, then click save, and other mappers will investigate. + the_map: the map communities: title: Communities lede_text: | @@ -2388,7 +2404,11 @@ en: public_traces_from: "Public GPS Traces from %{user}" description: "Browse recent GPS trace uploads" tagged_with: " tagged with %{tags}" - empty_html: "Nothing here yet. Upload a new trace or learn more about GPS tracing on the wiki page." + empty_title: Nothing here yet + empty_upload_html: "%{upload_link} or learn more about GPS tracing on the %{wiki_link}." + upload_new: Upload a new trace + wiki_page: wiki page + wiki_page_url: https://wiki.openstreetmap.org/wiki/Beginners_Guide_1.2 upload_trace: "Upload a trace" all_traces: "All Traces" my_traces: "My Traces" @@ -2553,10 +2573,8 @@ en: support: support about: header: Free and editable - html: | -

Unlike other maps, OpenStreetMap is completely created by people like you, - and it's free for anyone to fix, update, download and use.

-

Sign up to get started contributing. We'll send an email to confirm your account.

+ paragraph_1: Unlike other maps, OpenStreetMap is completely created by people like you, and it's free for anyone to fix, update, download and use. + paragraph_2: Sign up to get started contributing. We'll send an email to confirm your account. email address: "Email Address:" confirm email address: "Confirm Email Address:" display name: "Display Name:" diff --git a/test/controllers/traces_controller_test.rb b/test/controllers/traces_controller_test.rb index 8346debbf..cd9f5f127 100644 --- a/test/controllers/traces_controller_test.rb +++ b/test/controllers/traces_controller_test.rb @@ -756,7 +756,7 @@ class TracesControllerTest < ActionDispatch::IntegrationTest assert_template "index" if traces.empty? - assert_select "h4", /Nothing here yet/ + assert_select "h2", /Nothing here yet/ else assert_select "table#trace_list tbody", :count => 1 do assert_select "tr", :count => traces.length do |rows|