From: Tom Hughes <tom@compton.nu>
Date: Wed, 6 May 2020 13:06:04 +0000 (+0100)
Subject: Look at all note comments to find the close event
X-Git-Tag: live~2748
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/7e925c3c00cc5944fc743faf9d1509fcd30df55d

Look at all note comments to find the close event

Fixes #2612
---

diff --git a/app/models/note.rb b/app/models/note.rb
index ec57b770b..ea88599a4 100644
--- a/app/models/note.rb
+++ b/app/models/note.rb
@@ -22,6 +22,7 @@ class Note < ApplicationRecord
   include GeoRecord
 
   has_many :comments, -> { left_joins(:author).where(:visible => true, :users => { :status => [nil, "active", "confirmed"] }).order(:created_at) }, :class_name => "NoteComment", :foreign_key => :note_id
+  has_many :all_comments, -> { left_joins(:author).order(:created_at) }, :class_name => "NoteComment", :foreign_key => :note_id
 
   validates :id, :uniqueness => true, :presence => { :on => :update },
                  :numericality => { :on => :update, :only_integer => true }
diff --git a/app/views/browse/note.html.erb b/app/views/browse/note.html.erb
index 884f95d57..ffc198b0a 100644
--- a/app/views/browse/note.html.erb
+++ b/app/views/browse/note.html.erb
@@ -15,7 +15,7 @@
     <%= note_event("opened", @note.created_at, @note.author) %>
     <% if @note.status == "closed" %>
       <br />
-      <%= note_event(@note.status, @note.closed_at, @note_comments.last.author) %>
+      <%= note_event(@note.status, @note.closed_at, @note.all_comments.last.author) %>
     <% end %>
   </div>