From: Brian DeRocher <brian@derocher.org>
Date: Sun, 23 Oct 2022 20:00:38 +0000 (-0400)
Subject: get_text("reversegeocode/result") returns an XML node.  We want to get the text value... 
X-Git-Tag: live~1447^2
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/8eb2abc10cff2dd4b23a4d667db9d9db5731c972?ds=sidebyside

get_text("reversegeocode/result") returns an XML node.  We want to get the text value of that node.

This will unescape &#039; into an apostrophe.

All callers of this function will later re-encode it depending out output whether it be HTML in an email, or XML in an RSS feed.

* app/mailers/user_mail.rb
* app/helpers/geocode_helper.rb
* app/views/api/notes/feed.rss.builder
* app/views/api/notes/_note.rss.builder

Fixes openstreetmap/openstreetmap-website#3761
---

diff --git a/lib/nominatim.rb b/lib/nominatim.rb
index f847ec84e..adb041da4 100644
--- a/lib/nominatim.rb
+++ b/lib/nominatim.rb
@@ -19,7 +19,7 @@ module Nominatim
       end
 
       if response && result = response.get_text("reversegeocode/result")
-        result.to_s
+        result.value
       else
         "#{number_with_precision(lat, :precision => 3)}, #{number_with_precision(lon, :precision => 3)}"
       end