From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Mon, 22 Jun 2009 16:27:40 +0000 (+0000)
Subject: Add --untranslated-values to spot things that haven't been translated
X-Git-Tag: live~7590
X-Git-Url: https://git.openstreetmap.org./rails.git/commitdiff_plain/9721a9a96e70e8ce0624d06107c35bcff1ecd1f0

Add --untranslated-values to spot things that haven't been translated
---

diff --git a/script/locale/diff b/script/locale/diff
index d38f1c505..fdaf4a4fb 100755
--- a/script/locale/diff
+++ b/script/locale/diff
@@ -30,6 +30,18 @@ translated files when F<en.yml> changes.
 
 Print this help message.
 
+=item --diff-keys
+
+Show the hash keys that differ between the two files, useful merging
+new entries from F<en.yml> to a local file.
+
+=item --untranslated-values
+
+Show keys whose values are either exactly the same between the two
+files, or don't exist in the target file (the latter file specified).
+
+This helps to find untranslated values.
+
 =back
 
 =head1 AUTHOR
@@ -43,6 +55,8 @@ Getopt::Long::Parser->new(
     config => [ qw< bundling no_ignore_case no_require_order pass_through > ],
 )->getoptions(
     'h|help' => \my $help,
+    'diff-keys' => \my $diff_keys,
+    'undiff-values' => \my $undiff_values,
 ) or help();
 
 # On --help
@@ -59,18 +73,36 @@ my $to_data   = LoadFile($to);
 my $from_parsed = { iterate($from_data->{basename($from)}) };
 my $to_parsed = { iterate($to_data->{basename($to)}) };
 
-# Delete hash values
-#walkdepth \&delete_hash_values, $_ for $from_data, $to_data;
-
-# Hack around Test::Differences wanting a Test::* module loaded
-$INC{"Test.pm"} = 1;
-sub Test::ok { print shift }
+# Since this used to be the default, support that...
+if ((not $undiff_values and not $diff_keys) or $diff_keys)
+{
+    print_key_differences();
+}
+elsif ($undiff_values)
+{
+    my @untranslated = untranslated_keys($from_parsed, $to_parsed);
 
-# Diff the tree
-eq_or_diff([ sort keys %$from_parsed ], [ sort keys %$to_parsed ]);
+    print $_, "\n" for @untranslated;
+}
 
 exit 0;
 
+sub print_key_differences
+{
+    # Hack around Test::Differences wanting a Test::* module loaded
+    $INC{"Test.pm"} = 1;
+    sub Test::ok { print shift }
+
+    # Diff the tree
+    eq_or_diff([ sort keys %$from_parsed ], [ sort keys %$to_parsed ]);
+}
+
+sub untranslated_keys
+{
+    my ($from_parsed, $to_parsed) = @_;
+    sort grep { not exists $to_parsed->{$_} or $from_parsed->{$_} eq $to_parsed->{$_} } keys %$from_parsed;
+}
+
 sub iterate
 {
     my ($hash, @path) = @_;